* fix: close volumes and EC shards in tests to prevent Windows cleanup failures On Windows, t.TempDir() cleanup fails when test files are still open because Windows enforces mandatory file locking. Add defer v.Close(), defer store.Close(), and EC volume cleanup to ensure all file handles are released before temp directory removal. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: extract closeEcVolumes helper to reduce duplication Address code review feedback by extracting the repeated EC volume cleanup loop into a closeEcVolumes() helper function. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
170 lines
4.3 KiB
Go
170 lines
4.3 KiB
Go
package storage
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"os"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/needle"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/super_block"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/types"
|
|
)
|
|
|
|
func TestSearchVolumesWithDeletedNeedles(t *testing.T) {
|
|
dir := t.TempDir()
|
|
|
|
v, err := NewVolume(dir, dir, "", 1, NeedleMapInMemory, &super_block.ReplicaPlacement{}, &needle.TTL{}, 0, needle.GetCurrentVersion(), 0, 0)
|
|
if err != nil {
|
|
t.Fatalf("volume creation: %v", err)
|
|
}
|
|
defer v.Close()
|
|
|
|
count := 20
|
|
|
|
for i := 1; i < count; i++ {
|
|
n := newRandomNeedle(uint64(i))
|
|
_, _, _, err := v.writeNeedle2(n, true, false)
|
|
if err != nil {
|
|
t.Fatalf("write needle %d: %v", i, err)
|
|
}
|
|
}
|
|
|
|
for i := 1; i < 15; i++ {
|
|
n := newEmptyNeedle(uint64(i))
|
|
err := v.nm.Put(n.Id, types.Offset{}, types.TombstoneFileSize)
|
|
if err != nil {
|
|
t.Fatalf("delete needle %d: %v", i, err)
|
|
}
|
|
}
|
|
|
|
ts1 := time.Now().UnixNano()
|
|
|
|
for i := 15; i < count; i++ {
|
|
n := newEmptyNeedle(uint64(i))
|
|
_, err := v.doDeleteRequest(n)
|
|
if err != nil {
|
|
t.Fatalf("delete needle %d: %v", i, err)
|
|
}
|
|
}
|
|
|
|
offset, isLast, err := v.BinarySearchByAppendAtNs(uint64(ts1))
|
|
if err != nil {
|
|
t.Fatalf("lookup by ts: %v", err)
|
|
}
|
|
fmt.Printf("offset: %v, isLast: %v\n", offset.ToActualOffset(), isLast)
|
|
|
|
}
|
|
|
|
func isFileExist(path string) (bool, error) {
|
|
if _, err := os.Stat(path); err == nil {
|
|
return true, nil
|
|
} else if errors.Is(err, os.ErrNotExist) {
|
|
return false, nil
|
|
} else {
|
|
return false, err
|
|
}
|
|
}
|
|
|
|
func assertFileExist(t *testing.T, expected bool, path string) {
|
|
exist, err := isFileExist(path)
|
|
if err != nil {
|
|
t.Fatalf("isFileExist: %v", err)
|
|
}
|
|
assert.Equal(t, expected, exist)
|
|
}
|
|
|
|
func TestDestroyEmptyVolumeWithOnlyEmpty(t *testing.T) {
|
|
dir := t.TempDir()
|
|
|
|
v, err := NewVolume(dir, dir, "", 1, NeedleMapInMemory, &super_block.ReplicaPlacement{}, &needle.TTL{}, 0, needle.GetCurrentVersion(), 0, 0)
|
|
if err != nil {
|
|
t.Fatalf("volume creation: %v", err)
|
|
}
|
|
path := v.DataBackend.Name()
|
|
|
|
// should can Destroy empty volume with onlyEmpty
|
|
assertFileExist(t, true, path)
|
|
err = v.Destroy(true)
|
|
if err != nil {
|
|
t.Fatalf("destroy volume: %v", err)
|
|
}
|
|
assertFileExist(t, false, path)
|
|
}
|
|
|
|
func TestDestroyEmptyVolumeWithoutOnlyEmpty(t *testing.T) {
|
|
dir := t.TempDir()
|
|
|
|
v, err := NewVolume(dir, dir, "", 1, NeedleMapInMemory, &super_block.ReplicaPlacement{}, &needle.TTL{}, 0, needle.GetCurrentVersion(), 0, 0)
|
|
if err != nil {
|
|
t.Fatalf("volume creation: %v", err)
|
|
}
|
|
path := v.DataBackend.Name()
|
|
|
|
// should can Destroy empty volume without onlyEmpty
|
|
assertFileExist(t, true, path)
|
|
err = v.Destroy(false)
|
|
if err != nil {
|
|
t.Fatalf("destroy volume: %v", err)
|
|
}
|
|
assertFileExist(t, false, path)
|
|
}
|
|
|
|
func TestDestroyNonemptyVolumeWithOnlyEmpty(t *testing.T) {
|
|
dir := t.TempDir()
|
|
|
|
v, err := NewVolume(dir, dir, "", 1, NeedleMapInMemory, &super_block.ReplicaPlacement{}, &needle.TTL{}, 0, needle.GetCurrentVersion(), 0, 0)
|
|
if err != nil {
|
|
t.Fatalf("volume creation: %v", err)
|
|
}
|
|
defer v.Close()
|
|
path := v.DataBackend.Name()
|
|
|
|
// should return "volume not empty" error and do not delete file when Destroy non-empty volume
|
|
_, _, _, err = v.writeNeedle2(newRandomNeedle(1), true, false)
|
|
if err != nil {
|
|
t.Fatalf("write needle: %v", err)
|
|
}
|
|
assert.Equal(t, uint64(1), v.FileCount())
|
|
|
|
assertFileExist(t, true, path)
|
|
err = v.Destroy(true)
|
|
assert.EqualError(t, err, "volume not empty")
|
|
assertFileExist(t, true, path)
|
|
|
|
// should keep working after "volume not empty"
|
|
_, _, _, err = v.writeNeedle2(newRandomNeedle(2), true, false)
|
|
if err != nil {
|
|
t.Fatalf("write needle: %v", err)
|
|
}
|
|
|
|
assert.Equal(t, uint64(2), v.FileCount())
|
|
}
|
|
|
|
func TestDestroyNonemptyVolumeWithoutOnlyEmpty(t *testing.T) {
|
|
dir := t.TempDir()
|
|
|
|
v, err := NewVolume(dir, dir, "", 1, NeedleMapInMemory, &super_block.ReplicaPlacement{}, &needle.TTL{}, 0, needle.GetCurrentVersion(), 0, 0)
|
|
if err != nil {
|
|
t.Fatalf("volume creation: %v", err)
|
|
}
|
|
path := v.DataBackend.Name()
|
|
|
|
// should can Destroy non-empty volume without onlyEmpty
|
|
_, _, _, err = v.writeNeedle2(newRandomNeedle(1), true, false)
|
|
if err != nil {
|
|
t.Fatalf("write needle: %v", err)
|
|
}
|
|
assert.Equal(t, uint64(1), v.FileCount())
|
|
|
|
assertFileExist(t, true, path)
|
|
err = v.Destroy(false)
|
|
if err != nil {
|
|
t.Fatalf("destroy volume: %v", err)
|
|
}
|
|
assertFileExist(t, false, path)
|
|
}
|