c433fee36a
* s3api: fix AccessDenied by correctly propagating principal ARN in vended tokens * s3api: update TestLoadS3ApiConfiguration to match standardized ARN format * s3api: address PR review comments (nil-safety and cleanup) * s3api: address second round of PR review comments (cleanups and naming conventions) * s3api: address third round of PR review comments (unify default account ID and duplicate log) * s3api: address fourth round of PR review comments (define defaultAccountID as constant)
135 lines
2.9 KiB
Go
135 lines
2.9 KiB
Go
package s3api
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
|
|
)
|
|
|
|
// TestBuildResourceARN verifies that resource ARNs use the AWS-compatible format
|
|
func TestBuildResourceARN(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
bucket string
|
|
object string
|
|
expected string
|
|
}{
|
|
{
|
|
name: "bucket only",
|
|
bucket: "my-bucket",
|
|
object: "",
|
|
expected: "arn:aws:s3:::my-bucket",
|
|
},
|
|
{
|
|
name: "bucket with slash",
|
|
bucket: "my-bucket",
|
|
object: "/",
|
|
expected: "arn:aws:s3:::my-bucket",
|
|
},
|
|
{
|
|
name: "bucket and object",
|
|
bucket: "my-bucket",
|
|
object: "path/to/object.txt",
|
|
expected: "arn:aws:s3:::my-bucket/path/to/object.txt",
|
|
},
|
|
{
|
|
name: "bucket and object with leading slash",
|
|
bucket: "my-bucket",
|
|
object: "/path/to/object.txt",
|
|
expected: "arn:aws:s3:::my-bucket/path/to/object.txt",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
result := buildResourceARN(tt.bucket, tt.object)
|
|
if result != tt.expected {
|
|
t.Errorf("buildResourceARN(%q, %q) = %q, want %q", tt.bucket, tt.object, result, tt.expected)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestBuildPrincipalARN verifies that principal ARNs use the AWS-compatible format
|
|
func TestBuildPrincipalARN(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
identity *Identity
|
|
expected string
|
|
}{
|
|
{
|
|
name: "nil identity (anonymous)",
|
|
identity: nil,
|
|
expected: "*",
|
|
},
|
|
{
|
|
name: "explicit principal ARN",
|
|
identity: &Identity{
|
|
Name: "test-user",
|
|
PrincipalArn: "arn:aws:iam::123456789012:role/MyRole",
|
|
},
|
|
expected: "arn:aws:iam::123456789012:role/MyRole",
|
|
},
|
|
{
|
|
name: "anonymous user by name",
|
|
identity: &Identity{
|
|
Name: s3_constants.AccountAnonymousId,
|
|
Account: &Account{
|
|
Id: "123456789012",
|
|
},
|
|
},
|
|
expected: "*",
|
|
},
|
|
{
|
|
name: "anonymous user by account ID",
|
|
identity: &Identity{
|
|
Name: "test-user",
|
|
Account: &Account{
|
|
Id: s3_constants.AccountAnonymousId,
|
|
},
|
|
},
|
|
expected: "*",
|
|
},
|
|
{
|
|
name: "identity with account and name",
|
|
identity: &Identity{
|
|
Name: "test-user",
|
|
Account: &Account{
|
|
Id: "123456789012",
|
|
},
|
|
},
|
|
expected: "arn:aws:iam::123456789012:user/test-user",
|
|
},
|
|
{
|
|
name: "identity without account ID",
|
|
identity: &Identity{
|
|
Name: "test-user",
|
|
Account: &Account{
|
|
Id: "",
|
|
},
|
|
},
|
|
expected: fmt.Sprintf("arn:aws:iam::%s:user/test-user", defaultAccountID),
|
|
},
|
|
{
|
|
name: "identity without name",
|
|
identity: &Identity{
|
|
Name: "",
|
|
Account: &Account{
|
|
Id: "123456789012",
|
|
},
|
|
},
|
|
expected: "arn:aws:iam::123456789012:user/unknown",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
result := buildPrincipalARN(tt.identity, nil)
|
|
if result != tt.expected {
|
|
t.Errorf("buildPrincipalARN() = %q, want %q", result, tt.expected)
|
|
}
|
|
})
|
|
}
|
|
}
|