5167bbd2a9
The allowEmptyFolder option is no longer functional because: 1. The code that used it was already commented out 2. Empty folder cleanup is now handled asynchronously by EmptyFolderCleaner The CLI flags are kept for backward compatibility but marked as deprecated and ignored. This removes: - S3ApiServerOption.AllowEmptyFolder field - The actual usage in s3api_object_handlers_list.go - Helm chart values and template references - References in test Makefiles and docker-compose files
S3 Object Tagging Tests
This directory contains tests for S3 object tagging functionality.
Issue Reference
These tests were created to verify the fix for GitHub Issue #7589: S3 object Tags query comes back empty
Problem Description
When uploading an object with tags using the X-Amz-Tagging header, the tags were not being stored.
When querying the object tagging with GetObjectTagging, the response was empty.
This was a regression between SeaweedFS 4.00 and 4.01.
Root Cause
The putToFiler function in s3api_object_handlers_put.go was not parsing the X-Amz-Tagging header
and storing the tags in the entry's Extended metadata. The code was only copying user metadata
(headers starting with X-Amz-Meta-) but not object tags.
Fix
Added tag parsing logic to putToFiler that:
- Reads the
X-Amz-Taggingheader - Parses it using
url.ParseQuery()for proper URL decoding - Stores each tag with the prefix
X-Amz-Tagging-in the entry's Extended metadata
Running Tests
# Run all tagging tests
cd test/s3/tagging
make test
# Run specific test
make test-upload
# Or using go test directly
go test -v ./...
Test Cases
- TestObjectTaggingOnUpload - Basic test for tags sent during object upload
- TestObjectTaggingOnUploadWithSpecialCharacters - Tests URL-encoded tag values
- TestObjectTaggingOnUploadWithEmptyValue - Tests tags with empty values
- TestPutObjectTaggingAPI - Tests the PutObjectTagging API separately
- TestDeleteObjectTagging - Tests tag deletion
- TestTagsNotPreservedAfterObjectOverwrite - Verifies AWS S3 behavior on overwrite
- TestMaximumNumberOfTags - Tests storing the maximum 10 tags
- TestTagCountHeader - Tests the x-amz-tagging-count header in HeadObject