995dfc4d5d
* chore: remove unreachable dead code across the codebase Remove ~50,000 lines of unreachable code identified by static analysis. Major removals: - weed/filer/redis_lua: entire unused Redis Lua filer store implementation - weed/wdclient/net2, resource_pool: unused connection/resource pool packages - weed/plugin/worker/lifecycle: unused lifecycle plugin worker - weed/s3api: unused S3 policy templates, presigned URL IAM, streaming copy, multipart IAM, key rotation, and various SSE helper functions - weed/mq/kafka: unused partition mapping, compression, schema, and protocol functions - weed/mq/offset: unused SQL storage and migration code - weed/worker: unused registry, task, and monitoring functions - weed/query: unused SQL engine, parquet scanner, and type functions - weed/shell: unused EC proportional rebalance functions - weed/storage/erasure_coding/distribution: unused distribution analysis functions - Individual unreachable functions removed from 150+ files across admin, credential, filer, iam, kms, mount, mq, operation, pb, s3api, server, shell, storage, topology, and util packages * fix(s3): reset shared memory store in IAM test to prevent flaky failure TestLoadIAMManagerFromConfig_EmptyConfigWithFallbackKey was flaky because the MemoryStore credential backend is a singleton registered via init(). Earlier tests that create anonymous identities pollute the shared store, causing LookupAnonymous() to unexpectedly return true. Fix by calling Reset() on the memory store before the test runs. * style: run gofmt on changed files * fix: restore KMS functions used by integration tests * fix(plugin): prevent panic on send to closed worker session channel The Plugin.sendToWorker method could panic with "send on closed channel" when a worker disconnected while a message was being sent. The race was between streamSession.close() closing the outgoing channel and sendToWorker writing to it concurrently. Add a done channel to streamSession that is closed before the outgoing channel, and check it in sendToWorker's select to safely detect closed sessions without panicking.
106 lines
3.3 KiB
Go
106 lines
3.3 KiB
Go
package base
|
|
|
|
import (
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/admin/config"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/worker_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/worker/types"
|
|
)
|
|
|
|
// TaskDefinition encapsulates everything needed to define a complete task type
|
|
type TaskDefinition struct {
|
|
// Basic task information
|
|
Type types.TaskType
|
|
Name string
|
|
DisplayName string
|
|
Description string
|
|
Icon string
|
|
Capabilities []string
|
|
|
|
// Task configuration
|
|
Config TaskConfig
|
|
ConfigSpec ConfigSpec
|
|
|
|
// Task creation
|
|
CreateTask func(params *worker_pb.TaskParams) (types.Task, error)
|
|
|
|
// Detection logic
|
|
DetectionFunc func(metrics []*types.VolumeHealthMetrics, info *types.ClusterInfo, config TaskConfig) ([]*types.TaskDetectionResult, error)
|
|
ScanInterval time.Duration
|
|
|
|
// Scheduling logic
|
|
SchedulingFunc func(task *types.TaskInput, running []*types.TaskInput, workers []*types.WorkerData, config TaskConfig) bool
|
|
MaxConcurrent int
|
|
RepeatInterval time.Duration
|
|
}
|
|
|
|
// TaskConfig provides a configuration interface that supports type-safe defaults
|
|
type TaskConfig interface {
|
|
config.ConfigWithDefaults // Extends ConfigWithDefaults for type-safe schema operations
|
|
IsEnabled() bool
|
|
SetEnabled(bool)
|
|
ToTaskPolicy() *worker_pb.TaskPolicy
|
|
FromTaskPolicy(policy *worker_pb.TaskPolicy) error
|
|
}
|
|
|
|
// ConfigSpec defines the configuration schema
|
|
type ConfigSpec struct {
|
|
Fields []*config.Field
|
|
}
|
|
|
|
// BaseConfig provides common configuration fields with reflection-based serialization
|
|
type BaseConfig struct {
|
|
Enabled bool `json:"enabled"`
|
|
ScanIntervalSeconds int `json:"scan_interval_seconds"`
|
|
MaxConcurrent int `json:"max_concurrent"`
|
|
}
|
|
|
|
// IsEnabled returns whether the task is enabled
|
|
func (c *BaseConfig) IsEnabled() bool {
|
|
return c.Enabled
|
|
}
|
|
|
|
// SetEnabled sets whether the task is enabled
|
|
func (c *BaseConfig) SetEnabled(enabled bool) {
|
|
c.Enabled = enabled
|
|
}
|
|
|
|
// Validate validates the base configuration
|
|
func (c *BaseConfig) Validate() error {
|
|
// Common validation logic
|
|
return nil
|
|
}
|
|
|
|
// ToMap converts config to map using reflection
|
|
// ToTaskPolicy converts BaseConfig to protobuf (partial implementation)
|
|
// Note: Concrete implementations should override this to include task-specific config
|
|
func (c *BaseConfig) ToTaskPolicy() *worker_pb.TaskPolicy {
|
|
return &worker_pb.TaskPolicy{
|
|
Enabled: c.Enabled,
|
|
MaxConcurrent: int32(c.MaxConcurrent),
|
|
RepeatIntervalSeconds: int32(c.ScanIntervalSeconds),
|
|
CheckIntervalSeconds: int32(c.ScanIntervalSeconds),
|
|
// TaskConfig field should be set by concrete implementations
|
|
}
|
|
}
|
|
|
|
// FromTaskPolicy loads BaseConfig from protobuf (partial implementation)
|
|
// Note: Concrete implementations should override this to handle task-specific config
|
|
func (c *BaseConfig) FromTaskPolicy(policy *worker_pb.TaskPolicy) error {
|
|
if policy == nil {
|
|
return fmt.Errorf("policy is nil")
|
|
}
|
|
c.Enabled = policy.Enabled
|
|
c.MaxConcurrent = int(policy.MaxConcurrent)
|
|
c.ScanIntervalSeconds = int(policy.RepeatIntervalSeconds)
|
|
return nil
|
|
}
|
|
|
|
// ApplySchemaDefaults applies default values from schema using reflection
|
|
func (c *BaseConfig) ApplySchemaDefaults(schema *config.Schema) error {
|
|
// Use reflection-based approach for BaseConfig since it needs to handle embedded structs
|
|
return schema.ApplyDefaultsToProtobuf(c)
|
|
}
|