8056b702ba
* feat(balance): add replica placement validation for volume moves When the volume balance detection proposes moving a volume, validate that the move does not violate the volume's replication policy (e.g., ReplicaPlacement=010 requires replicas on different racks). If the preferred destination violates the policy, fall back to score-based planning; if that also violates, skip the volume entirely. - Add ReplicaLocation type and VolumeReplicaMap to ClusterInfo - Build replica map from all volumes before collection filtering - Port placement validation logic from command_volume_fix_replication.go - Thread replica map through collectVolumeMetrics call chain - Add IsGoodMove check in createBalanceTask before destination use * address PR review: extract validation closure, add defensive checks - Extract validateMove closure to eliminate duplicated ReplicaLocation construction and IsGoodMove calls - Add defensive check for empty replica map entries (len(replicas) == 0) - Add bounds check for int-to-byte cast on ExpectedReplicas (0-255) * address nitpick: rp test helper accepts *testing.T and fails on error Prevents silent failures from typos in replica placement codes. * address review: add composite replica placement tests (011, 110) Test multi-constraint placement policies where both rack and DC rules must be satisfied simultaneously. * address review: use struct keys instead of string concatenation Replace string-concatenated map keys with typed rackKey/nodeKey structs to eliminate allocations and avoid ambiguity if IDs contain spaces. * address review: simplify bounds check, log fallback error, guard source - Remove unreachable ExpectedReplicas < 0 branch (outer condition already guarantees > 0), fold bounds check into single condition - Log error from planBalanceDestination in replica validation fallback - Return false from IsGoodMove when sourceNodeID not found in existing replicas (inconsistent cluster state) * address review: use slices.Contains instead of hand-rolled helpers Replace isAmongDC and isAmongRack with slices.Contains from the standard library, reducing boilerplate.
110 lines
3.2 KiB
Go
110 lines
3.2 KiB
Go
package pluginworker
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/master_pb"
|
|
)
|
|
|
|
func makeTestVolumeListResponse(volumes ...*master_pb.VolumeInformationMessage) *master_pb.VolumeListResponse {
|
|
return &master_pb.VolumeListResponse{
|
|
VolumeSizeLimitMb: 30000,
|
|
TopologyInfo: &master_pb.TopologyInfo{
|
|
DataCenterInfos: []*master_pb.DataCenterInfo{
|
|
{
|
|
Id: "dc1",
|
|
RackInfos: []*master_pb.RackInfo{
|
|
{
|
|
Id: "rack1",
|
|
DataNodeInfos: []*master_pb.DataNodeInfo{
|
|
{
|
|
Id: "server1:8080",
|
|
DiskInfos: map[string]*master_pb.DiskInfo{
|
|
"hdd": {
|
|
VolumeInfos: volumes,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func TestBuildVolumeMetricsEmptyFilter(t *testing.T) {
|
|
resp := makeTestVolumeListResponse(
|
|
&master_pb.VolumeInformationMessage{Id: 1, Collection: "photos", Size: 100},
|
|
&master_pb.VolumeInformationMessage{Id: 2, Collection: "videos", Size: 200},
|
|
)
|
|
metrics, _, _, err := buildVolumeMetrics(resp, "")
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if len(metrics) != 2 {
|
|
t.Fatalf("expected 2 metrics, got %d", len(metrics))
|
|
}
|
|
}
|
|
|
|
func TestBuildVolumeMetricsAllCollections(t *testing.T) {
|
|
resp := makeTestVolumeListResponse(
|
|
&master_pb.VolumeInformationMessage{Id: 1, Collection: "photos", Size: 100},
|
|
&master_pb.VolumeInformationMessage{Id: 2, Collection: "videos", Size: 200},
|
|
)
|
|
metrics, _, _, err := buildVolumeMetrics(resp, collectionFilterAll)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if len(metrics) != 2 {
|
|
t.Fatalf("expected 2 metrics, got %d", len(metrics))
|
|
}
|
|
}
|
|
|
|
func TestBuildVolumeMetricsEachCollection(t *testing.T) {
|
|
resp := makeTestVolumeListResponse(
|
|
&master_pb.VolumeInformationMessage{Id: 1, Collection: "photos", Size: 100},
|
|
&master_pb.VolumeInformationMessage{Id: 2, Collection: "videos", Size: 200},
|
|
)
|
|
// EACH_COLLECTION passes all volumes through; filtering happens in the handler
|
|
metrics, _, _, err := buildVolumeMetrics(resp, collectionFilterEach)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if len(metrics) != 2 {
|
|
t.Fatalf("expected 2 metrics, got %d", len(metrics))
|
|
}
|
|
}
|
|
|
|
func TestBuildVolumeMetricsRegexFilter(t *testing.T) {
|
|
resp := makeTestVolumeListResponse(
|
|
&master_pb.VolumeInformationMessage{Id: 1, Collection: "photos", Size: 100},
|
|
&master_pb.VolumeInformationMessage{Id: 2, Collection: "videos", Size: 200},
|
|
&master_pb.VolumeInformationMessage{Id: 3, Collection: "photos-backup", Size: 300},
|
|
)
|
|
metrics, _, _, err := buildVolumeMetrics(resp, "^photos$")
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if len(metrics) != 1 {
|
|
t.Fatalf("expected 1 metric, got %d", len(metrics))
|
|
}
|
|
if metrics[0].Collection != "photos" {
|
|
t.Fatalf("expected collection 'photos', got %q", metrics[0].Collection)
|
|
}
|
|
}
|
|
|
|
func TestBuildVolumeMetricsInvalidRegex(t *testing.T) {
|
|
resp := makeTestVolumeListResponse(
|
|
&master_pb.VolumeInformationMessage{Id: 1, Collection: "photos", Size: 100},
|
|
)
|
|
_, _, _, err := buildVolumeMetrics(resp, "[invalid")
|
|
if err == nil {
|
|
t.Fatal("expected error for invalid regex")
|
|
}
|
|
if !isConfigError(err) {
|
|
t.Fatalf("expected config error for invalid regex, got: %v", err)
|
|
}
|
|
}
|