72a8f598f2
* fix float stepping * do not auto refresh * only logs when non 200 status * fix maintenance task sorting and cleanup redundant handler logic * Refactor log retrieval to persist to disk and fix slowness - Move log retrieval to disk-based persistence in GetMaintenanceTaskDetail - Implement background log fetching on task completion in worker_grpc_server.go - Implement async background refresh for in-progress tasks - Completely remove blocking gRPC calls from the UI path to fix 10s timeouts - Cleanup debug logs and performance profiling code * Ensure consistent deterministic sorting in config_persistence cleanup * Replace magic numbers with constants and remove debug logs - Added descriptive constants for truncation limits and timeouts in admin_server.go and worker_grpc_server.go - Replaced magic numbers with these constants throughout the codebase - Verified removal of stdout debug printing - Ensured consistent truncation logic during log persistence * Address code review feedback on history truncation and logging logic - Fix AssignmentHistory double-serialization by copying task in GetMaintenanceTaskDetail - Fix handleTaskCompletion logging logic (mutually exclusive success/failure logs) - Remove unused Timeout field from LogRequestContext and sync select timeouts with constants - Ensure AssignmentHistory is only provided in the top-level field for better JSON structure * Implement goroutine leak protection and request deduplication - Add request deduplication in RequestTaskLogs to prevent multiple concurrent fetches for the same task - Implement safe cleanup in timeout handlers to avoid race conditions in pendingLogRequests map - Add a 10s cooldown for background log refreshes in GetMaintenanceTaskDetail to prevent spamming - Ensure all persistent log-fetching goroutines are bounded and efficiently managed * Fix potential nil pointer panics in maintenance handlers - Add nil checks for adminServer in ShowTaskDetail, ShowMaintenanceWorkers, and UpdateTaskConfig - Update getMaintenanceQueueData to return a descriptive error instead of nil when adminServer is uninitialized - Ensure internal helper methods consistently check for adminServer initialization before use * Strictly enforce disk-only log reading - Remove background log fetching from GetMaintenanceTaskDetail to prevent timeouts and network calls during page view - Remove unused lastLogFetch tracking fields to clean up dead code - Ensure logs are only updated upon task completion via handleTaskCompletion * Refactor GetWorkerLogs to read from disk - Update /api/maintenance/workers/:id/logs endpoint to use configPersistence.LoadTaskExecutionLogs - Remove synchronous gRPC call RequestTaskLogs to prevent timeouts and bad gateway errors - Ensure consistent log retrieval behavior across the application (disk-only) * Fix timestamp parsing in log viewer - Update task_detail.templ JS to handle both ISO 8601 strings and Unix timestamps - Fix "Invalid time value" error when displaying logs fetched from disk - Regenerate templates * master: fallback to HDD if SSD volumes are full in Assign * worker: improve EC detection logging and fix skip counters * worker: add Sync method to TaskLogger interface * worker: implement Sync and ensure logs are flushed before task completion * admin: improve task log retrieval with retries and better timeouts * admin: robust timestamp parsing in task detail view
410 lines
21 KiB
Plaintext
410 lines
21 KiB
Plaintext
package app
|
|
|
|
import (
|
|
"fmt"
|
|
"time"
|
|
"github.com/seaweedfs/seaweedfs/weed/admin/maintenance"
|
|
)
|
|
|
|
templ MaintenanceQueue(data *maintenance.MaintenanceQueueData) {
|
|
<div class="container-fluid">
|
|
<!-- Header -->
|
|
<div class="row mb-4">
|
|
<div class="col-12">
|
|
<div class="d-flex justify-content-between align-items-center">
|
|
<h2 class="mb-0">
|
|
<i class="fas fa-tasks me-2"></i>
|
|
Maintenance Queue
|
|
</h2>
|
|
<div class="btn-group">
|
|
<button type="button" class="btn btn-primary" onclick="triggerScan()">
|
|
<i class="fas fa-search me-1"></i>
|
|
Trigger Scan
|
|
</button>
|
|
<button type="button" class="btn btn-secondary" onclick="refreshPage()">
|
|
<i class="fas fa-sync-alt me-1"></i>
|
|
Refresh
|
|
</button>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<!-- Statistics Cards -->
|
|
<div class="row mb-4">
|
|
<div class="col-md-3">
|
|
<div class="card border-primary">
|
|
<div class="card-body text-center">
|
|
<i class="fas fa-clock fa-2x text-primary mb-2"></i>
|
|
<h4 class="mb-1">{fmt.Sprintf("%d", data.Stats.PendingTasks)}</h4>
|
|
<p class="text-muted mb-0">Pending Tasks</p>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<div class="col-md-3">
|
|
<div class="card border-warning">
|
|
<div class="card-body text-center">
|
|
<i class="fas fa-running fa-2x text-warning mb-2"></i>
|
|
<h4 class="mb-1">{fmt.Sprintf("%d", data.Stats.RunningTasks)}</h4>
|
|
<p class="text-muted mb-0">Running Tasks</p>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<div class="col-md-3">
|
|
<div class="card border-success">
|
|
<div class="card-body text-center">
|
|
<i class="fas fa-check-circle fa-2x text-success mb-2"></i>
|
|
<h4 class="mb-1">{fmt.Sprintf("%d", data.Stats.CompletedToday)}</h4>
|
|
<p class="text-muted mb-0">Completed Today</p>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<div class="col-md-3">
|
|
<div class="card border-danger">
|
|
<div class="card-body text-center">
|
|
<i class="fas fa-exclamation-triangle fa-2x text-danger mb-2"></i>
|
|
<h4 class="mb-1">{fmt.Sprintf("%d", data.Stats.FailedToday)}</h4>
|
|
<p class="text-muted mb-0">Failed Today</p>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<!-- Completed Tasks -->
|
|
<div class="row mb-4">
|
|
<div class="col-12">
|
|
<div class="card">
|
|
<div class="card-header bg-success text-white">
|
|
<h5 class="mb-0">
|
|
<i class="fas fa-check-circle me-2"></i>
|
|
Completed Tasks
|
|
</h5>
|
|
</div>
|
|
<div class="card-body">
|
|
if data.Stats.CompletedToday == 0 && data.Stats.FailedToday == 0 {
|
|
<div class="text-center text-muted py-4">
|
|
<i class="fas fa-check-circle fa-3x mb-3"></i>
|
|
<p>No completed maintenance tasks today</p>
|
|
<small>Completed tasks will appear here after workers finish processing them</small>
|
|
</div>
|
|
} else {
|
|
<div class="table-responsive">
|
|
<table class="table table-hover">
|
|
<thead>
|
|
<tr>
|
|
<th>Type</th>
|
|
<th>Status</th>
|
|
<th>Volume</th>
|
|
<th>Worker</th>
|
|
<th>Duration</th>
|
|
<th>Completed</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
for _, task := range data.Tasks {
|
|
if string(task.Status) == "completed" || string(task.Status) == "failed" || string(task.Status) == "cancelled" {
|
|
if string(task.Status) == "failed" {
|
|
<tr class="table-danger clickable-row" data-task-id={task.ID} onclick="navigateToTask(this)" style="cursor: pointer;">
|
|
<td>
|
|
@TaskTypeIcon(task.Type)
|
|
{string(task.Type)}
|
|
</td>
|
|
<td>@StatusBadge(task.Status)</td>
|
|
<td>{fmt.Sprintf("%d", task.VolumeID)}</td>
|
|
<td>
|
|
if task.WorkerID != "" {
|
|
<small>{task.WorkerID}</small>
|
|
} else {
|
|
<span class="text-muted">-</span>
|
|
}
|
|
</td>
|
|
<td>
|
|
if task.StartedAt != nil && task.CompletedAt != nil {
|
|
{formatDuration(task.CompletedAt.Sub(*task.StartedAt))}
|
|
} else {
|
|
<span class="text-muted">-</span>
|
|
}
|
|
</td>
|
|
<td>
|
|
if task.CompletedAt != nil {
|
|
{task.CompletedAt.Format("2006-01-02 15:04")}
|
|
} else {
|
|
<span class="text-muted">-</span>
|
|
}
|
|
</td>
|
|
</tr>
|
|
} else {
|
|
<tr class="clickable-row" data-task-id={task.ID} onclick="navigateToTask(this)" style="cursor: pointer;">
|
|
<td>
|
|
@TaskTypeIcon(task.Type)
|
|
{string(task.Type)}
|
|
</td>
|
|
<td>@StatusBadge(task.Status)</td>
|
|
<td>{fmt.Sprintf("%d", task.VolumeID)}</td>
|
|
<td>
|
|
if task.WorkerID != "" {
|
|
<small>{task.WorkerID}</small>
|
|
} else {
|
|
<span class="text-muted">-</span>
|
|
}
|
|
</td>
|
|
<td>
|
|
if task.StartedAt != nil && task.CompletedAt != nil {
|
|
{formatDuration(task.CompletedAt.Sub(*task.StartedAt))}
|
|
} else {
|
|
<span class="text-muted">-</span>
|
|
}
|
|
</td>
|
|
<td>
|
|
if task.CompletedAt != nil {
|
|
{task.CompletedAt.Format("2006-01-02 15:04")}
|
|
} else {
|
|
<span class="text-muted">-</span>
|
|
}
|
|
</td>
|
|
</tr>
|
|
}
|
|
}
|
|
}
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<!-- Pending Tasks -->
|
|
<div class="row mb-4">
|
|
<div class="col-12">
|
|
<div class="card">
|
|
<div class="card-header bg-primary text-white">
|
|
<h5 class="mb-0">
|
|
<i class="fas fa-clock me-2"></i>
|
|
Pending Tasks
|
|
</h5>
|
|
</div>
|
|
<div class="card-body">
|
|
if data.Stats.PendingTasks == 0 {
|
|
<div class="text-center text-muted py-4">
|
|
<i class="fas fa-clipboard-list fa-3x mb-3"></i>
|
|
<p>No pending maintenance tasks</p>
|
|
<small>Pending tasks will appear here when the system detects maintenance needs</small>
|
|
</div>
|
|
} else {
|
|
<div class="table-responsive">
|
|
<table class="table table-hover">
|
|
<thead>
|
|
<tr>
|
|
<th>Type</th>
|
|
<th>Priority</th>
|
|
<th>Volume</th>
|
|
<th>Server</th>
|
|
<th>Reason</th>
|
|
<th>Created</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
for _, task := range data.Tasks {
|
|
if string(task.Status) == "pending" {
|
|
<tr class="clickable-row" data-task-id={task.ID} onclick="navigateToTask(this)" style="cursor: pointer;">
|
|
<td>
|
|
@TaskTypeIcon(task.Type)
|
|
{string(task.Type)}
|
|
</td>
|
|
<td>@PriorityBadge(task.Priority)</td>
|
|
<td>{fmt.Sprintf("%d", task.VolumeID)}</td>
|
|
<td><small>{task.Server}</small></td>
|
|
<td><small>{task.Reason}</small></td>
|
|
<td>{task.CreatedAt.Format("2006-01-02 15:04")}</td>
|
|
</tr>
|
|
}
|
|
}
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<!-- Active Tasks -->
|
|
<div class="row mb-4">
|
|
<div class="col-12">
|
|
<div class="card">
|
|
<div class="card-header bg-warning text-dark">
|
|
<h5 class="mb-0">
|
|
<i class="fas fa-running me-2"></i>
|
|
Active Tasks
|
|
</h5>
|
|
</div>
|
|
<div class="card-body">
|
|
if data.Stats.RunningTasks == 0 {
|
|
<div class="text-center text-muted py-4">
|
|
<i class="fas fa-tasks fa-3x mb-3"></i>
|
|
<p>No active maintenance tasks</p>
|
|
<small>Active tasks will appear here when workers start processing them</small>
|
|
</div>
|
|
} else {
|
|
<div class="table-responsive">
|
|
<table class="table table-hover">
|
|
<thead>
|
|
<tr>
|
|
<th>Type</th>
|
|
<th>Status</th>
|
|
<th>Progress</th>
|
|
<th>Volume</th>
|
|
<th>Worker</th>
|
|
<th>Started</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
for _, task := range data.Tasks {
|
|
if string(task.Status) == "assigned" || string(task.Status) == "in_progress" {
|
|
<tr class="clickable-row" data-task-id={task.ID} onclick="navigateToTask(this)" style="cursor: pointer;">
|
|
<td>
|
|
@TaskTypeIcon(task.Type)
|
|
{string(task.Type)}
|
|
</td>
|
|
<td>@StatusBadge(task.Status)</td>
|
|
<td>@ProgressBar(task.Progress, task.Status)</td>
|
|
<td>{fmt.Sprintf("%d", task.VolumeID)}</td>
|
|
<td>
|
|
if task.WorkerID != "" {
|
|
<small>{task.WorkerID}</small>
|
|
} else {
|
|
<span class="text-muted">-</span>
|
|
}
|
|
</td>
|
|
<td>
|
|
if task.StartedAt != nil {
|
|
{task.StartedAt.Format("2006-01-02 15:04")}
|
|
} else {
|
|
<span class="text-muted">-</span>
|
|
}
|
|
</td>
|
|
</tr>
|
|
}
|
|
}
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<script>
|
|
// Debug output to browser console
|
|
console.log("DEBUG: Maintenance Queue Template loaded");
|
|
|
|
|
|
|
|
window.triggerScan = function() {
|
|
console.log("triggerScan called");
|
|
fetch('/api/maintenance/scan', {
|
|
method: 'POST',
|
|
headers: {
|
|
'Content-Type': 'application/json',
|
|
}
|
|
})
|
|
.then(response => response.json())
|
|
.then(data => {
|
|
if (data.success) {
|
|
showToast('Success', 'Maintenance scan triggered successfully', 'success');
|
|
setTimeout(() => window.location.reload(), 2000);
|
|
} else {
|
|
showToast('Error', 'Failed to trigger scan: ' + (data.error || 'Unknown error'), 'danger');
|
|
}
|
|
})
|
|
.catch(error => {
|
|
showToast('Error', 'Error: ' + error.message, 'danger');
|
|
});
|
|
};
|
|
|
|
window.refreshPage = function() {
|
|
console.log("refreshPage called");
|
|
window.location.reload();
|
|
};
|
|
|
|
window.navigateToTask = function(element) {
|
|
const taskId = element.getAttribute('data-task-id');
|
|
if (taskId) {
|
|
window.location.href = '/maintenance/tasks/' + taskId;
|
|
}
|
|
};
|
|
</script>
|
|
}
|
|
|
|
// Helper components
|
|
templ TaskTypeIcon(taskType maintenance.MaintenanceTaskType) {
|
|
<i class={maintenance.GetTaskIcon(taskType) + " me-1"}></i>
|
|
}
|
|
|
|
templ PriorityBadge(priority maintenance.MaintenanceTaskPriority) {
|
|
switch priority {
|
|
case maintenance.PriorityCritical:
|
|
<span class="badge bg-danger">Critical</span>
|
|
case maintenance.PriorityHigh:
|
|
<span class="badge bg-warning">High</span>
|
|
case maintenance.PriorityNormal:
|
|
<span class="badge bg-primary">Normal</span>
|
|
case maintenance.PriorityLow:
|
|
<span class="badge bg-secondary">Low</span>
|
|
default:
|
|
<span class="badge bg-light text-dark">Unknown</span>
|
|
}
|
|
}
|
|
|
|
templ StatusBadge(status maintenance.MaintenanceTaskStatus) {
|
|
switch status {
|
|
case maintenance.TaskStatusPending:
|
|
<span class="badge bg-secondary">Pending</span>
|
|
case maintenance.TaskStatusAssigned:
|
|
<span class="badge bg-info">Assigned</span>
|
|
case maintenance.TaskStatusInProgress:
|
|
<span class="badge bg-warning">Running</span>
|
|
case maintenance.TaskStatusCompleted:
|
|
<span class="badge bg-success">Completed</span>
|
|
case maintenance.TaskStatusFailed:
|
|
<span class="badge bg-danger">Failed</span>
|
|
case maintenance.TaskStatusCancelled:
|
|
<span class="badge bg-light text-dark">Cancelled</span>
|
|
default:
|
|
<span class="badge bg-light text-dark">Unknown</span>
|
|
}
|
|
}
|
|
|
|
templ ProgressBar(progress float64, status maintenance.MaintenanceTaskStatus) {
|
|
if status == maintenance.TaskStatusInProgress || status == maintenance.TaskStatusAssigned {
|
|
<div class="progress" style="height: 8px; min-width: 100px;">
|
|
<div class="progress-bar" role="progressbar" style={fmt.Sprintf("width: %.1f%%", progress)}>
|
|
</div>
|
|
</div>
|
|
<small class="text-muted">{fmt.Sprintf("%.1f%%", progress)}</small>
|
|
} else if status == maintenance.TaskStatusCompleted {
|
|
<div class="progress" style="height: 8px; min-width: 100px;">
|
|
<div class="progress-bar bg-success" role="progressbar" style="width: 100%">
|
|
</div>
|
|
</div>
|
|
<small class="text-success">100%</small>
|
|
} else {
|
|
<span class="text-muted">-</span>
|
|
}
|
|
}
|
|
|
|
func formatDuration(d time.Duration) string {
|
|
if d < time.Minute {
|
|
return fmt.Sprintf("%.0fs", d.Seconds())
|
|
} else if d < time.Hour {
|
|
return fmt.Sprintf("%.1fm", d.Minutes())
|
|
} else {
|
|
return fmt.Sprintf("%.1fh", d.Hours())
|
|
}
|
|
}
|
|
|
|
|