995dfc4d5d
* chore: remove unreachable dead code across the codebase Remove ~50,000 lines of unreachable code identified by static analysis. Major removals: - weed/filer/redis_lua: entire unused Redis Lua filer store implementation - weed/wdclient/net2, resource_pool: unused connection/resource pool packages - weed/plugin/worker/lifecycle: unused lifecycle plugin worker - weed/s3api: unused S3 policy templates, presigned URL IAM, streaming copy, multipart IAM, key rotation, and various SSE helper functions - weed/mq/kafka: unused partition mapping, compression, schema, and protocol functions - weed/mq/offset: unused SQL storage and migration code - weed/worker: unused registry, task, and monitoring functions - weed/query: unused SQL engine, parquet scanner, and type functions - weed/shell: unused EC proportional rebalance functions - weed/storage/erasure_coding/distribution: unused distribution analysis functions - Individual unreachable functions removed from 150+ files across admin, credential, filer, iam, kms, mount, mq, operation, pb, s3api, server, shell, storage, topology, and util packages * fix(s3): reset shared memory store in IAM test to prevent flaky failure TestLoadIAMManagerFromConfig_EmptyConfigWithFallbackKey was flaky because the MemoryStore credential backend is a singleton registered via init(). Earlier tests that create anonymous identities pollute the shared store, causing LookupAnonymous() to unexpectedly return true. Fix by calling Reset() on the memory store before the test runs. * style: run gofmt on changed files * fix: restore KMS functions used by integration tests * fix(plugin): prevent panic on send to closed worker session channel The Plugin.sendToWorker method could panic with "send on closed channel" when a worker disconnected while a message was being sent. The race was between streamSession.close() closing the outgoing channel and sendToWorker writing to it concurrently. Add a done channel to streamSession that is closed before the outgoing channel, and check it in sendToWorker's select to safely detect closed sessions without panicking.
85 lines
2.4 KiB
Go
85 lines
2.4 KiB
Go
package needle
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/backend"
|
|
. "github.com/seaweedfs/seaweedfs/weed/storage/types"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
"github.com/seaweedfs/seaweedfs/weed/util/buffer_pool"
|
|
)
|
|
|
|
func (n *Needle) Append(w backend.BackendStorageFile, version Version) (offset uint64, size Size, actualSize int64, err error) {
|
|
end, _, e := w.GetStat()
|
|
if e != nil {
|
|
err = fmt.Errorf("Cannot Read Current Volume Position: %w", e)
|
|
return
|
|
}
|
|
offset = uint64(end)
|
|
if offset >= MaxPossibleVolumeSize && len(n.Data) != 0 {
|
|
err = fmt.Errorf("Volume Size %d Exceeded %d", offset, MaxPossibleVolumeSize)
|
|
return
|
|
}
|
|
bytesBuffer := buffer_pool.SyncPoolGetBuffer()
|
|
defer func() {
|
|
if err != nil {
|
|
if te := w.Truncate(end); te != nil {
|
|
// handle error or log
|
|
}
|
|
}
|
|
buffer_pool.SyncPoolPutBuffer(bytesBuffer)
|
|
}()
|
|
|
|
size, actualSize, err = writeNeedleByVersion(version, n, offset, bytesBuffer)
|
|
if err != nil {
|
|
return
|
|
}
|
|
|
|
_, err = w.WriteAt(bytesBuffer.Bytes(), int64(offset))
|
|
if err != nil {
|
|
err = fmt.Errorf("failed to write %d bytes to %s at offset %d: %w", actualSize, w.Name(), offset, err)
|
|
}
|
|
|
|
return offset, size, actualSize, err
|
|
}
|
|
|
|
func WriteNeedleBlob(w backend.BackendStorageFile, dataSlice []byte, size Size, appendAtNs uint64, version Version) (offset uint64, err error) {
|
|
|
|
if end, _, e := w.GetStat(); e == nil {
|
|
defer func(w backend.BackendStorageFile, off int64) {
|
|
if err != nil {
|
|
if te := w.Truncate(end); te != nil {
|
|
glog.V(0).Infof("Failed to truncate %s back to %d with error: %v", w.Name(), end, te)
|
|
}
|
|
}
|
|
}(w, end)
|
|
offset = uint64(end)
|
|
} else {
|
|
err = fmt.Errorf("Cannot Read Current Volume Position: %v", e)
|
|
return
|
|
}
|
|
|
|
if version == Version3 {
|
|
// compute byte offset as int to compare and slice correctly
|
|
tsOffset := int(NeedleHeaderSize) + int(size) + NeedleChecksumSize
|
|
// Ensure dataSlice has enough capacity for the timestamp
|
|
if tsOffset < 0 {
|
|
err = fmt.Errorf("invalid needle size %d results in negative timestamp offset %d", size, tsOffset)
|
|
return
|
|
}
|
|
if tsOffset+TimestampSize > len(dataSlice) {
|
|
err = fmt.Errorf("needle blob buffer too small: need %d bytes, have %d", tsOffset+TimestampSize, len(dataSlice))
|
|
return
|
|
}
|
|
util.Uint64toBytes(dataSlice[tsOffset:tsOffset+TimestampSize], appendAtNs)
|
|
}
|
|
|
|
if err == nil {
|
|
_, err = w.WriteAt(dataSlice, int64(offset))
|
|
}
|
|
|
|
return
|
|
|
|
}
|