14cd0f53ba
* Places the CommonResponse struct at the end of all IAM responses, rather than the start. * iam: fix error response request id layout * iam: add XML ordering regression test * iam: share request id generation --------- Co-authored-by: Aaron Segal <aaron.segal@rpsolutions.com> Co-authored-by: Chris Lu <chris.lu@gmail.com>
49 lines
1.5 KiB
Go
49 lines
1.5 KiB
Go
package iamapi
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"github.com/aws/aws-sdk-go/service/iam"
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3err"
|
|
)
|
|
|
|
func newErrorResponse(errCode string, errMsg string) ErrorResponse {
|
|
errorResp := ErrorResponse{}
|
|
errorResp.Error.Type = "Sender"
|
|
errorResp.Error.Code = &errCode
|
|
errorResp.Error.Message = &errMsg
|
|
errorResp.SetRequestId()
|
|
return errorResp
|
|
}
|
|
|
|
func writeIamErrorResponse(w http.ResponseWriter, r *http.Request, iamError *IamError) {
|
|
|
|
if iamError == nil {
|
|
// Do nothing if there is no error
|
|
glog.Errorf("No error found")
|
|
return
|
|
}
|
|
|
|
errCode := iamError.Code
|
|
errMsg := iamError.Error.Error()
|
|
glog.Errorf("Response %+v", errMsg)
|
|
|
|
errorResp := newErrorResponse(errCode, errMsg)
|
|
internalErrorResponse := newErrorResponse(iam.ErrCodeServiceFailureException, "Internal server error")
|
|
|
|
switch errCode {
|
|
case iam.ErrCodeNoSuchEntityException:
|
|
s3err.WriteXMLResponse(w, r, http.StatusNotFound, errorResp)
|
|
case iam.ErrCodeMalformedPolicyDocumentException, iam.ErrCodeInvalidInputException:
|
|
s3err.WriteXMLResponse(w, r, http.StatusBadRequest, errorResp)
|
|
case iam.ErrCodeDeleteConflictException:
|
|
s3err.WriteXMLResponse(w, r, http.StatusConflict, errorResp)
|
|
case iam.ErrCodeServiceFailureException:
|
|
// We do not want to expose internal server error to the client
|
|
s3err.WriteXMLResponse(w, r, http.StatusInternalServerError, internalErrorResponse)
|
|
default:
|
|
s3err.WriteXMLResponse(w, r, http.StatusInternalServerError, internalErrorResponse)
|
|
}
|
|
}
|