* chore: remove unreachable dead code across the codebase Remove ~50,000 lines of unreachable code identified by static analysis. Major removals: - weed/filer/redis_lua: entire unused Redis Lua filer store implementation - weed/wdclient/net2, resource_pool: unused connection/resource pool packages - weed/plugin/worker/lifecycle: unused lifecycle plugin worker - weed/s3api: unused S3 policy templates, presigned URL IAM, streaming copy, multipart IAM, key rotation, and various SSE helper functions - weed/mq/kafka: unused partition mapping, compression, schema, and protocol functions - weed/mq/offset: unused SQL storage and migration code - weed/worker: unused registry, task, and monitoring functions - weed/query: unused SQL engine, parquet scanner, and type functions - weed/shell: unused EC proportional rebalance functions - weed/storage/erasure_coding/distribution: unused distribution analysis functions - Individual unreachable functions removed from 150+ files across admin, credential, filer, iam, kms, mount, mq, operation, pb, s3api, server, shell, storage, topology, and util packages * fix(s3): reset shared memory store in IAM test to prevent flaky failure TestLoadIAMManagerFromConfig_EmptyConfigWithFallbackKey was flaky because the MemoryStore credential backend is a singleton registered via init(). Earlier tests that create anonymous identities pollute the shared store, causing LookupAnonymous() to unexpectedly return true. Fix by calling Reset() on the memory store before the test runs. * style: run gofmt on changed files * fix: restore KMS functions used by integration tests * fix(plugin): prevent panic on send to closed worker session channel The Plugin.sendToWorker method could panic with "send on closed channel" when a worker disconnected while a message was being sent. The race was between streamSession.close() closing the outgoing channel and sendToWorker writing to it concurrently. Add a done channel to streamSession that is closed before the outgoing channel, and check it in sendToWorker's select to safely detect closed sessions without panicking.
87 lines
2.6 KiB
Go
87 lines
2.6 KiB
Go
package tasks
|
|
|
|
import (
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/worker_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/worker/types"
|
|
)
|
|
|
|
// BaseUIProvider provides common UIProvider functionality for all tasks
|
|
type BaseUIProvider struct {
|
|
taskType types.TaskType
|
|
displayName string
|
|
description string
|
|
icon string
|
|
schemaFunc func() *TaskConfigSchema
|
|
configFunc func() types.TaskConfig
|
|
applyTaskPolicyFunc func(policy *worker_pb.TaskPolicy) error
|
|
applyTaskConfigFunc func(config types.TaskConfig) error
|
|
}
|
|
|
|
// NewBaseUIProvider creates a new base UI provider
|
|
func NewBaseUIProvider(
|
|
taskType types.TaskType,
|
|
displayName string,
|
|
description string,
|
|
icon string,
|
|
schemaFunc func() *TaskConfigSchema,
|
|
configFunc func() types.TaskConfig,
|
|
applyTaskPolicyFunc func(policy *worker_pb.TaskPolicy) error,
|
|
applyTaskConfigFunc func(config types.TaskConfig) error,
|
|
) *BaseUIProvider {
|
|
return &BaseUIProvider{
|
|
taskType: taskType,
|
|
displayName: displayName,
|
|
description: description,
|
|
icon: icon,
|
|
schemaFunc: schemaFunc,
|
|
configFunc: configFunc,
|
|
applyTaskPolicyFunc: applyTaskPolicyFunc,
|
|
applyTaskConfigFunc: applyTaskConfigFunc,
|
|
}
|
|
}
|
|
|
|
// GetTaskType returns the task type
|
|
func (ui *BaseUIProvider) GetTaskType() types.TaskType {
|
|
return ui.taskType
|
|
}
|
|
|
|
// GetDisplayName returns the human-readable name
|
|
func (ui *BaseUIProvider) GetDisplayName() string {
|
|
return ui.displayName
|
|
}
|
|
|
|
// GetDescription returns a description of what this task does
|
|
func (ui *BaseUIProvider) GetDescription() string {
|
|
return ui.description
|
|
}
|
|
|
|
// GetIcon returns the icon CSS class for this task type
|
|
func (ui *BaseUIProvider) GetIcon() string {
|
|
return ui.icon
|
|
}
|
|
|
|
// GetCurrentConfig returns the current configuration as TaskConfig
|
|
func (ui *BaseUIProvider) GetCurrentConfig() types.TaskConfig {
|
|
return ui.configFunc()
|
|
}
|
|
|
|
// ApplyTaskPolicy applies protobuf TaskPolicy configuration
|
|
func (ui *BaseUIProvider) ApplyTaskPolicy(policy *worker_pb.TaskPolicy) error {
|
|
return ui.applyTaskPolicyFunc(policy)
|
|
}
|
|
|
|
// ApplyTaskConfig applies TaskConfig interface configuration
|
|
func (ui *BaseUIProvider) ApplyTaskConfig(config types.TaskConfig) error {
|
|
return ui.applyTaskConfigFunc(config)
|
|
}
|
|
|
|
// CommonConfigGetter provides a common pattern for getting current configuration
|
|
type CommonConfigGetter[T any] struct {
|
|
defaultConfig T
|
|
detectorFunc func() T
|
|
schedulerFunc func() T
|
|
}
|
|
|
|
// RegisterUIFunc provides a common registration function signature
|
|
type RegisterUIFunc[D, S any] func(uiRegistry *types.UIRegistry, detector D, scheduler S)
|