995dfc4d5d
* chore: remove unreachable dead code across the codebase Remove ~50,000 lines of unreachable code identified by static analysis. Major removals: - weed/filer/redis_lua: entire unused Redis Lua filer store implementation - weed/wdclient/net2, resource_pool: unused connection/resource pool packages - weed/plugin/worker/lifecycle: unused lifecycle plugin worker - weed/s3api: unused S3 policy templates, presigned URL IAM, streaming copy, multipart IAM, key rotation, and various SSE helper functions - weed/mq/kafka: unused partition mapping, compression, schema, and protocol functions - weed/mq/offset: unused SQL storage and migration code - weed/worker: unused registry, task, and monitoring functions - weed/query: unused SQL engine, parquet scanner, and type functions - weed/shell: unused EC proportional rebalance functions - weed/storage/erasure_coding/distribution: unused distribution analysis functions - Individual unreachable functions removed from 150+ files across admin, credential, filer, iam, kms, mount, mq, operation, pb, s3api, server, shell, storage, topology, and util packages * fix(s3): reset shared memory store in IAM test to prevent flaky failure TestLoadIAMManagerFromConfig_EmptyConfigWithFallbackKey was flaky because the MemoryStore credential backend is a singleton registered via init(). Earlier tests that create anonymous identities pollute the shared store, causing LookupAnonymous() to unexpectedly return true. Fix by calling Reset() on the memory store before the test runs. * style: run gofmt on changed files * fix: restore KMS functions used by integration tests * fix(plugin): prevent panic on send to closed worker session channel The Plugin.sendToWorker method could panic with "send on closed channel" when a worker disconnected while a message was being sent. The race was between streamSession.close() closing the outgoing channel and sendToWorker writing to it concurrently. Add a done channel to streamSession that is closed before the outgoing channel, and check it in sendToWorker's select to safely detect closed sessions without panicking.
70 lines
1.8 KiB
Go
70 lines
1.8 KiB
Go
package tasks
|
|
|
|
import (
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/worker_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/worker/types"
|
|
)
|
|
|
|
// BaseTask provides common functionality for all tasks
|
|
type BaseTask struct {
|
|
taskType types.TaskType
|
|
taskID string
|
|
progress float64
|
|
cancelled bool
|
|
mutex sync.RWMutex
|
|
startTime time.Time
|
|
estimatedDuration time.Duration
|
|
logger TaskLogger
|
|
loggerConfig TaskLoggerConfig
|
|
progressCallback func(float64, string) // Callback function for progress updates
|
|
currentStage string // Current stage description
|
|
}
|
|
|
|
// UnsupportedTaskTypeError represents an error for unsupported task types
|
|
type UnsupportedTaskTypeError struct {
|
|
TaskType types.TaskType
|
|
}
|
|
|
|
// BaseTaskFactory provides common functionality for task factories
|
|
type BaseTaskFactory struct {
|
|
taskType types.TaskType
|
|
capabilities []string
|
|
description string
|
|
}
|
|
|
|
// NewBaseTaskFactory creates a new base task factory
|
|
func NewBaseTaskFactory(taskType types.TaskType, capabilities []string, description string) *BaseTaskFactory {
|
|
return &BaseTaskFactory{
|
|
taskType: taskType,
|
|
capabilities: capabilities,
|
|
description: description,
|
|
}
|
|
}
|
|
|
|
// Capabilities returns the capabilities required for this task type
|
|
func (f *BaseTaskFactory) Capabilities() []string {
|
|
return f.capabilities
|
|
}
|
|
|
|
// Description returns the description of this task type
|
|
func (f *BaseTaskFactory) Description() string {
|
|
return f.description
|
|
}
|
|
|
|
// ValidationError represents a parameter validation error
|
|
type ValidationError struct {
|
|
Field string
|
|
Message string
|
|
}
|
|
|
|
// getServerFromSources extracts the server address from unified sources
|
|
func getServerFromSources(sources []*worker_pb.TaskSource) string {
|
|
if len(sources) > 0 {
|
|
return sources[0].Node
|
|
}
|
|
return ""
|
|
}
|