* chore: remove unreachable dead code across the codebase Remove ~50,000 lines of unreachable code identified by static analysis. Major removals: - weed/filer/redis_lua: entire unused Redis Lua filer store implementation - weed/wdclient/net2, resource_pool: unused connection/resource pool packages - weed/plugin/worker/lifecycle: unused lifecycle plugin worker - weed/s3api: unused S3 policy templates, presigned URL IAM, streaming copy, multipart IAM, key rotation, and various SSE helper functions - weed/mq/kafka: unused partition mapping, compression, schema, and protocol functions - weed/mq/offset: unused SQL storage and migration code - weed/worker: unused registry, task, and monitoring functions - weed/query: unused SQL engine, parquet scanner, and type functions - weed/shell: unused EC proportional rebalance functions - weed/storage/erasure_coding/distribution: unused distribution analysis functions - Individual unreachable functions removed from 150+ files across admin, credential, filer, iam, kms, mount, mq, operation, pb, s3api, server, shell, storage, topology, and util packages * fix(s3): reset shared memory store in IAM test to prevent flaky failure TestLoadIAMManagerFromConfig_EmptyConfigWithFallbackKey was flaky because the MemoryStore credential backend is a singleton registered via init(). Earlier tests that create anonymous identities pollute the shared store, causing LookupAnonymous() to unexpectedly return true. Fix by calling Reset() on the memory store before the test runs. * style: run gofmt on changed files * fix: restore KMS functions used by integration tests * fix(plugin): prevent panic on send to closed worker session channel The Plugin.sendToWorker method could panic with "send on closed channel" when a worker disconnected while a message was being sent. The race was between streamSession.close() closing the outgoing channel and sendToWorker writing to it concurrently. Add a done channel to streamSession that is closed before the outgoing channel, and check it in sendToWorker's select to safely detect closed sessions without panicking.
379 lines
11 KiB
Go
379 lines
11 KiB
Go
package offset
|
|
|
|
import (
|
|
"fmt"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/schema_pb"
|
|
)
|
|
|
|
// PartitionOffsetManager manages sequential offset assignment for a single partition
|
|
type PartitionOffsetManager struct {
|
|
mu sync.RWMutex
|
|
namespace string
|
|
topicName string
|
|
partition *schema_pb.Partition
|
|
nextOffset int64
|
|
|
|
// Checkpointing for recovery
|
|
lastCheckpoint int64
|
|
lastCheckpointedOffset int64
|
|
storage OffsetStorage
|
|
|
|
// Background checkpointing
|
|
stopCheckpoint chan struct{}
|
|
}
|
|
|
|
// OffsetStorage interface for persisting offset state
|
|
type OffsetStorage interface {
|
|
// SaveCheckpoint persists the current offset state for recovery
|
|
// Takes topic information along with partition to determine the correct storage location
|
|
SaveCheckpoint(namespace, topicName string, partition *schema_pb.Partition, offset int64) error
|
|
|
|
// LoadCheckpoint retrieves the last saved offset state
|
|
LoadCheckpoint(namespace, topicName string, partition *schema_pb.Partition) (int64, error)
|
|
|
|
// GetHighestOffset scans storage to find the highest assigned offset
|
|
GetHighestOffset(namespace, topicName string, partition *schema_pb.Partition) (int64, error)
|
|
}
|
|
|
|
// NewPartitionOffsetManager creates a new offset manager for a partition
|
|
func NewPartitionOffsetManager(namespace, topicName string, partition *schema_pb.Partition, storage OffsetStorage) (*PartitionOffsetManager, error) {
|
|
manager := &PartitionOffsetManager{
|
|
namespace: namespace,
|
|
topicName: topicName,
|
|
partition: partition,
|
|
storage: storage,
|
|
stopCheckpoint: make(chan struct{}),
|
|
}
|
|
|
|
// Recover offset state
|
|
if err := manager.recover(); err != nil {
|
|
return nil, fmt.Errorf("failed to recover offset state: %w", err)
|
|
}
|
|
|
|
// Start background checkpoint goroutine
|
|
go manager.runPeriodicCheckpoint()
|
|
|
|
return manager, nil
|
|
}
|
|
|
|
// Close stops the background checkpoint goroutine and performs a final checkpoint
|
|
func (m *PartitionOffsetManager) Close() error {
|
|
close(m.stopCheckpoint)
|
|
|
|
// Perform final checkpoint
|
|
m.mu.RLock()
|
|
currentOffset := m.nextOffset - 1 // Last assigned offset
|
|
lastCheckpointed := m.lastCheckpointedOffset
|
|
m.mu.RUnlock()
|
|
|
|
if currentOffset >= 0 && currentOffset > lastCheckpointed {
|
|
return m.storage.SaveCheckpoint(m.namespace, m.topicName, m.partition, currentOffset)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// AssignOffset assigns the next sequential offset
|
|
func (m *PartitionOffsetManager) AssignOffset() int64 {
|
|
m.mu.Lock()
|
|
offset := m.nextOffset
|
|
m.nextOffset++
|
|
m.mu.Unlock()
|
|
|
|
return offset
|
|
}
|
|
|
|
// AssignOffsets assigns a batch of sequential offsets
|
|
func (m *PartitionOffsetManager) AssignOffsets(count int64) (baseOffset int64, lastOffset int64) {
|
|
m.mu.Lock()
|
|
baseOffset = m.nextOffset
|
|
lastOffset = m.nextOffset + count - 1
|
|
m.nextOffset += count
|
|
m.mu.Unlock()
|
|
|
|
return baseOffset, lastOffset
|
|
}
|
|
|
|
// GetNextOffset returns the next offset that will be assigned
|
|
func (m *PartitionOffsetManager) GetNextOffset() int64 {
|
|
m.mu.RLock()
|
|
defer m.mu.RUnlock()
|
|
return m.nextOffset
|
|
}
|
|
|
|
// GetHighWaterMark returns the high water mark (next offset)
|
|
func (m *PartitionOffsetManager) GetHighWaterMark() int64 {
|
|
return m.GetNextOffset()
|
|
}
|
|
|
|
// recover restores offset state from storage
|
|
func (m *PartitionOffsetManager) recover() error {
|
|
var checkpointOffset int64 = -1
|
|
var highestOffset int64 = -1
|
|
|
|
// Try to load checkpoint
|
|
if offset, err := m.storage.LoadCheckpoint(m.namespace, m.topicName, m.partition); err == nil && offset >= 0 {
|
|
checkpointOffset = offset
|
|
}
|
|
|
|
// Try to scan storage for highest offset
|
|
if offset, err := m.storage.GetHighestOffset(m.namespace, m.topicName, m.partition); err == nil && offset >= 0 {
|
|
highestOffset = offset
|
|
}
|
|
|
|
// Use the higher of checkpoint or storage scan
|
|
if checkpointOffset >= 0 && highestOffset >= 0 {
|
|
if highestOffset > checkpointOffset {
|
|
m.nextOffset = highestOffset + 1
|
|
m.lastCheckpoint = highestOffset
|
|
m.lastCheckpointedOffset = highestOffset
|
|
} else {
|
|
m.nextOffset = checkpointOffset + 1
|
|
m.lastCheckpoint = checkpointOffset
|
|
m.lastCheckpointedOffset = checkpointOffset
|
|
}
|
|
} else if checkpointOffset >= 0 {
|
|
m.nextOffset = checkpointOffset + 1
|
|
m.lastCheckpoint = checkpointOffset
|
|
m.lastCheckpointedOffset = checkpointOffset
|
|
} else if highestOffset >= 0 {
|
|
m.nextOffset = highestOffset + 1
|
|
m.lastCheckpoint = highestOffset
|
|
m.lastCheckpointedOffset = highestOffset
|
|
} else {
|
|
// No data exists, start from 0
|
|
m.nextOffset = 0
|
|
m.lastCheckpoint = -1
|
|
m.lastCheckpointedOffset = -1
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// runPeriodicCheckpoint runs in the background and checkpoints every 2 seconds if the offset changed
|
|
func (m *PartitionOffsetManager) runPeriodicCheckpoint() {
|
|
ticker := time.NewTicker(2 * time.Second)
|
|
defer ticker.Stop()
|
|
|
|
for {
|
|
select {
|
|
case <-ticker.C:
|
|
m.performCheckpointIfChanged()
|
|
case <-m.stopCheckpoint:
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
// performCheckpointIfChanged saves checkpoint only if offset has changed since last checkpoint
|
|
func (m *PartitionOffsetManager) performCheckpointIfChanged() {
|
|
m.mu.RLock()
|
|
currentOffset := m.nextOffset - 1 // Last assigned offset
|
|
lastCheckpointed := m.lastCheckpointedOffset
|
|
m.mu.RUnlock()
|
|
|
|
// Skip if no messages have been assigned, or no change since last checkpoint
|
|
if currentOffset < 0 || currentOffset == lastCheckpointed {
|
|
return
|
|
}
|
|
|
|
// Perform checkpoint
|
|
if err := m.storage.SaveCheckpoint(m.namespace, m.topicName, m.partition, currentOffset); err != nil {
|
|
// Log error but don't fail - checkpointing is for optimization
|
|
fmt.Printf("Failed to checkpoint offset %d for %s/%s: %v\n", currentOffset, m.namespace, m.topicName, err)
|
|
return
|
|
}
|
|
|
|
// Update last checkpointed offset
|
|
m.mu.Lock()
|
|
m.lastCheckpointedOffset = currentOffset
|
|
m.lastCheckpoint = currentOffset
|
|
m.mu.Unlock()
|
|
}
|
|
|
|
// PartitionOffsetRegistry manages offset managers for multiple partitions
|
|
type PartitionOffsetRegistry struct {
|
|
mu sync.RWMutex
|
|
managers map[string]*PartitionOffsetManager
|
|
storage OffsetStorage
|
|
}
|
|
|
|
// NewPartitionOffsetRegistry creates a new registry
|
|
func NewPartitionOffsetRegistry(storage OffsetStorage) *PartitionOffsetRegistry {
|
|
return &PartitionOffsetRegistry{
|
|
managers: make(map[string]*PartitionOffsetManager),
|
|
storage: storage,
|
|
}
|
|
}
|
|
|
|
// GetManager returns the offset manager for a partition, creating it if needed
|
|
func (r *PartitionOffsetRegistry) GetManager(namespace, topicName string, partition *schema_pb.Partition) (*PartitionOffsetManager, error) {
|
|
// CRITICAL FIX: Use TopicPartitionKey to ensure each topic has its own offset manager
|
|
key := TopicPartitionKey(namespace, topicName, partition)
|
|
|
|
r.mu.RLock()
|
|
manager, exists := r.managers[key]
|
|
r.mu.RUnlock()
|
|
|
|
if exists {
|
|
return manager, nil
|
|
}
|
|
|
|
// Create new manager
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
|
|
// Double-check after acquiring write lock
|
|
if manager, exists := r.managers[key]; exists {
|
|
return manager, nil
|
|
}
|
|
|
|
manager, err := NewPartitionOffsetManager(namespace, topicName, partition, r.storage)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
r.managers[key] = manager
|
|
return manager, nil
|
|
}
|
|
|
|
// AssignOffset assigns an offset for the given partition
|
|
func (r *PartitionOffsetRegistry) AssignOffset(namespace, topicName string, partition *schema_pb.Partition) (int64, error) {
|
|
manager, err := r.GetManager(namespace, topicName, partition)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
|
|
assignedOffset := manager.AssignOffset()
|
|
|
|
return assignedOffset, nil
|
|
}
|
|
|
|
// AssignOffsets assigns a batch of offsets for the given partition
|
|
func (r *PartitionOffsetRegistry) AssignOffsets(namespace, topicName string, partition *schema_pb.Partition, count int64) (baseOffset, lastOffset int64, err error) {
|
|
manager, err := r.GetManager(namespace, topicName, partition)
|
|
if err != nil {
|
|
return 0, 0, err
|
|
}
|
|
|
|
baseOffset, lastOffset = manager.AssignOffsets(count)
|
|
return baseOffset, lastOffset, nil
|
|
}
|
|
|
|
// GetHighWaterMark returns the high water mark for a partition
|
|
func (r *PartitionOffsetRegistry) GetHighWaterMark(namespace, topicName string, partition *schema_pb.Partition) (int64, error) {
|
|
manager, err := r.GetManager(namespace, topicName, partition)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
|
|
return manager.GetHighWaterMark(), nil
|
|
}
|
|
|
|
// Close stops all partition managers and performs final checkpoints
|
|
func (r *PartitionOffsetRegistry) Close() error {
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
|
|
var firstErr error
|
|
for _, manager := range r.managers {
|
|
if err := manager.Close(); err != nil && firstErr == nil {
|
|
firstErr = err
|
|
}
|
|
}
|
|
|
|
return firstErr
|
|
}
|
|
|
|
// TopicPartitionKey generates a unique key for a topic-partition combination
|
|
// This is the canonical key format used across the offset management system
|
|
func TopicPartitionKey(namespace, topicName string, partition *schema_pb.Partition) string {
|
|
return fmt.Sprintf("%s/%s/ring:%d:range:%d-%d",
|
|
namespace, topicName,
|
|
partition.RingSize, partition.RangeStart, partition.RangeStop)
|
|
}
|
|
|
|
// PartitionKey generates a unique key for a partition (without topic context)
|
|
// Note: UnixTimeNs is intentionally excluded from the key because it represents
|
|
// partition creation time, not partition identity. Using it would cause offset
|
|
// tracking to reset whenever a partition is recreated or looked up again.
|
|
// DEPRECATED: Use TopicPartitionKey for production code to avoid key collisions
|
|
func PartitionKey(partition *schema_pb.Partition) string {
|
|
return fmt.Sprintf("ring:%d:range:%d-%d",
|
|
partition.RingSize, partition.RangeStart, partition.RangeStop)
|
|
}
|
|
|
|
// partitionKey is the internal lowercase version for backward compatibility within this package
|
|
func partitionKey(partition *schema_pb.Partition) string {
|
|
return PartitionKey(partition)
|
|
}
|
|
|
|
// OffsetAssignment represents an assigned offset with metadata
|
|
type OffsetAssignment struct {
|
|
Offset int64
|
|
Timestamp int64
|
|
Partition *schema_pb.Partition
|
|
}
|
|
|
|
// BatchOffsetAssignment represents a batch of assigned offsets
|
|
type BatchOffsetAssignment struct {
|
|
BaseOffset int64
|
|
LastOffset int64
|
|
Count int64
|
|
Timestamp int64
|
|
Partition *schema_pb.Partition
|
|
}
|
|
|
|
// AssignmentResult contains the result of offset assignment
|
|
type AssignmentResult struct {
|
|
Assignment *OffsetAssignment
|
|
Batch *BatchOffsetAssignment
|
|
Error error
|
|
}
|
|
|
|
// OffsetAssigner provides high-level offset assignment operations
|
|
type OffsetAssigner struct {
|
|
registry *PartitionOffsetRegistry
|
|
}
|
|
|
|
// AssignSingleOffset assigns a single offset with timestamp
|
|
func (a *OffsetAssigner) AssignSingleOffset(namespace, topicName string, partition *schema_pb.Partition) *AssignmentResult {
|
|
offset, err := a.registry.AssignOffset(namespace, topicName, partition)
|
|
if err != nil {
|
|
return &AssignmentResult{Error: err}
|
|
}
|
|
|
|
return &AssignmentResult{
|
|
Assignment: &OffsetAssignment{
|
|
Offset: offset,
|
|
Timestamp: time.Now().UnixNano(),
|
|
Partition: partition,
|
|
},
|
|
}
|
|
}
|
|
|
|
// AssignBatchOffsets assigns a batch of offsets with timestamp
|
|
func (a *OffsetAssigner) AssignBatchOffsets(namespace, topicName string, partition *schema_pb.Partition, count int64) *AssignmentResult {
|
|
baseOffset, lastOffset, err := a.registry.AssignOffsets(namespace, topicName, partition, count)
|
|
if err != nil {
|
|
return &AssignmentResult{Error: err}
|
|
}
|
|
|
|
return &AssignmentResult{
|
|
Batch: &BatchOffsetAssignment{
|
|
BaseOffset: baseOffset,
|
|
LastOffset: lastOffset,
|
|
Count: count,
|
|
Timestamp: time.Now().UnixNano(),
|
|
Partition: partition,
|
|
},
|
|
}
|
|
}
|
|
|
|
// GetHighWaterMark returns the high water mark for a partition
|
|
func (a *OffsetAssigner) GetHighWaterMark(namespace, topicName string, partition *schema_pb.Partition) (int64, error) {
|
|
return a.registry.GetHighWaterMark(namespace, topicName, partition)
|
|
}
|