* mount: refresh and evict hot dir cache
* mount: guard dir update window and extend TTL
* mount: reuse timestamp for cache mark
* Apply suggestion from @gemini-code-assist[bot]
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* mount: make dir cache tuning configurable
* mount: dedupe dir update notices
* mount: restore invalidate-all cache helper
* mount: keep hot dir tuning constants
* mount: centralize cache state reset
* mount: mark refresh completion time
* mount: allow disabling idle eviction
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* Add shared s3tables manager
* Add s3tables shell commands
* Add s3tables admin API
* Add s3tables admin UI
* Fix admin s3tables namespace create
* Rename table buckets menu
* Centralize s3tables tag validation
* Reuse s3tables manager in admin
* Extract s3tables list limit
* Add s3tables bucket ARN helper
* Remove write middleware from s3tables APIs
* Fix bucket link and policy hint
* Fix table tag parsing and nav link
* Disable namespace table link on invalid ARN
* Improve s3tables error decode
* Return flag parse errors for s3tables tag
* Accept query params for namespace create
* Bind namespace create form data
* Read s3tables JS data from DOM
* s3tables: allow empty region ARN
* shell: pass s3tables account id
* shell: require account for table buckets
* shell: use bucket name for namespaces
* shell: use bucket name for tables
* shell: use bucket name for tags
* admin: add table buckets links in file browser
* s3api: reuse s3tables tag validation
* admin: harden s3tables UI handlers
* fix admin list table buckets
* allow admin s3tables access
* validate s3tables bucket tags
* log s3tables bucket metadata errors
* rollback table bucket on owner failure
* show s3tables bucket owner
* add s3tables iam conditions
* Add s3tables user permissions UI
* Authorize s3tables using identity actions
* Add s3tables permissions to user modal
* Disambiguate bucket scope in user permissions
* Block table bucket names that match S3 buckets
* Pretty-print IAM identity JSON
* Include tags in s3tables permission context
* admin: refactor S3 Tables inline JavaScript into a separate file
* s3tables: extend IAM policy condition operators support
* shell: use LookupEntry wrapper for s3tables bucket conflict check
* admin: handle buildBucketPermissions validation in create/update flows
* fix: use path instead of filepath to handle urls in weed admin file browser
* test: add comprehensive tests for file browser path handling
- Test breadcrumb generation for various path scenarios
- Test path handling with forward slashes (URL compatibility)
- Test parent path calculation for Windows compatibility
- Test file extension handling using path.Ext
- Test bucket path detection logic
These tests verify that the switch from filepath to path package works
correctly and handles URLs properly across all platforms.
* refactor: simplify fullPath construction using path.Join
Replace verbose manual path construction with path.Join which:
- Handles trailing slashes automatically
- Is more concise and readable
- Is more robust for edge cases
* fix: normalize path in ShowFileBrowser and rename generateBreadcrumbs parameter
Critical fix:
- Add util.CleanWindowsPath() normalization to path parameter in ShowFileBrowser
handler, matching the pattern used in other file operation handlers
(lines 273, 464)
- This ensures Windows-style backslashes are converted to forward slashes
before processing, fixing path handling issues on Windows
Consistency improvement:
- Rename path parameter to dir in generateBreadcrumbs function
- Aligns with parameter rename in GetFileBrowser for consistent naming
throughout the file
* test: improve coverage for Windows path handling and production code behavior
Address reviewer feedback by enhancing test quality:
1. Improved test documentation:
- Added clear comments explaining what each test validates
- Clarified that some tests validate expected behavior vs production code
- Documented the Windows path normalization flow
2. Enhanced actual production code testing:
- TestGenerateBreadcrumbs: Calls actual production function
- TestBreadcrumbPathFormatting: Validates production output format
- TestDirectoryNavigation: Integration-style test for complete flow
3. Added new test functions for better coverage:
- TestPathJoinHandlesEdgeCases: Verifies path.Join behavior
- TestWindowsPathNormalizationBehavior: Documents expected normalization
- TestDirectoryNavigation: Complete navigation flow test
4. Improved test organization:
- Fixed duplicate field naming issues
- Better test names for clarity
- More comprehensive edge case coverage
These improvements ensure the fix for issue #7628 (Windows path handling)
is properly validated across the complete flow from handler to path logic.
* test: use actual util.CleanWindowsPath function in Windows path normalization test
Address reviewer feedback by testing the actual production function:
- Import util package for CleanWindowsPath
- Call the real util.CleanWindowsPath() instead of reimplementing logic
- Ensures test validates actual implementation, not just expected behavior
- Added more test cases for edge cases (simple path, deep nesting)
This change validates that the Windows path normalization in the
ShowFileBrowser handler (handlers/file_browser_handlers.go:64)
works correctly with the actual util.CleanWindowsPath function.
* style: fix indentation in TestPathJoinHandlesEdgeCases
Align t.Errorf statement inside the if block with proper indentation.
The error message now correctly aligns with the if block body,
maintaining consistent indentation throughout the function.
* test: restore backslash validation check in TestPathJoinHandlesEdgeCases
---------
Co-authored-by: Chris Lu <chris.lu@gmail.com>
