Add table operations test (#8241)
* Add Trino blog operations test * Update test/s3tables/catalog_trino/trino_blog_operations_test.go Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * feat: add table bucket path helpers and filer operations - Add table object root and table location mapping directories - Implement ensureDirectory, upsertFile, deleteEntryIfExists helpers - Support table location bucket mapping for S3 access * feat: manage table bucket object roots on creation/deletion - Create .objects directory for table buckets on creation - Clean up table object bucket paths on deletion - Enable S3 operations on table bucket object roots * feat: add table location mapping for Iceberg REST - Track table location bucket mappings when tables are created/updated/deleted - Enable location-based routing for S3 operations on table data * feat: route S3 operations to table bucket object roots - Route table-s3 bucket names to mapped table paths - Route table buckets to object root directories - Support table location bucket mapping lookup * feat: emit table-s3 locations from Iceberg REST - Generate unique table-s3 bucket names with UUID suffix - Store table metadata under table bucket paths - Return table-s3 locations for Trino compatibility * fix: handle missing directories in S3 list operations - Propagate ErrNotFound from ListEntries for non-existent directories - Treat missing directories as empty results for list operations - Fixes Trino non-empty location checks on table creation * test: improve Trino CSV parsing for single-value results - Sanitize Trino output to skip jline warnings - Handle single-value CSV results without header rows - Strip quotes from numeric values in tests * refactor: use bucket path helpers throughout S3 API - Replace direct bucket path operations with helper functions - Leverage centralized table bucket routing logic - Improve maintainability with consistent path resolution * fix: add table bucket cache and improve filer error handling - Cache table bucket lookups to reduce filer overhead on repeated checks - Use filer_pb.CreateEntry and filer_pb.UpdateEntry helpers to check resp.Error - Fix delete order in handler_bucket_get_list_delete: delete table object before directory - Make location mapping errors best-effort: log and continue, don't fail API - Update table location mappings to delete stale prior bucket mappings on update - Add 1-second sleep before timestamp time travel query to ensure timestamps are in past - Fix CSV parsing: examine all lines, not skip first; handle single-value rows * fix: properly handle stale metadata location mapping cleanup - Capture oldMetadataLocation before mutation in handleUpdateTable - Update updateTableLocationMapping to accept both old and new locations - Use passed-in oldMetadataLocation to detect location changes - Delete stale mapping only when location actually changes - Pass empty string for oldLocation in handleCreateTable (new tables have no prior mapping) - Improve logging to show old -> new location transitions * refactor: cleanup imports and cache design - Remove unused 'sync' import from bucket_paths.go - Use filer_pb.UpdateEntry helper in setExtendedAttribute and deleteExtendedAttribute for consistent error handling - Add dedicated tableBucketCache map[string]bool to BucketRegistry instead of mixing concerns with metadataCache - Improve cache separation: table buckets cache is now separate from bucket metadata cache * fix: improve cache invalidation and add transient error handling Cache invalidation (critical fix): - Add tableLocationCache to BucketRegistry for location mapping lookups - Clear tableBucketCache and tableLocationCache in RemoveBucketMetadata - Prevents stale cache entries when buckets are deleted/recreated Transient error handling: - Only cache table bucket lookups when conclusive (found or ErrNotFound) - Skip caching on transient errors (network, permission, etc) - Prevents marking real table buckets as non-table due to transient failures Performance optimization: - Cache tableLocationDir results to avoid repeated filer RPCs on hot paths - tableLocationDir now checks cache before making expensive filer lookups - Cache stores empty string for 'not found' to avoid redundant lookups Code clarity: - Add comment to deleteDirectory explaining DeleteEntry response lacks Error field * go fmt * fix: mirror transient error handling in tableLocationDir and optimize bucketDir Transient error handling: - tableLocationDir now only caches definitive results - Mirrors isTableBucket behavior to prevent treating transient errors as permanent misses - Improves reliability on flaky systems or during recovery Performance optimization: - bucketDir avoids redundant isTableBucket call via bucketRoot - Directly use s3a.option.BucketsPath for regular buckets - Saves one cache lookup for every non-table bucket operation * fix: revert bucketDir optimization to preserve bucketRoot logic The optimization to directly use BucketsPath bypassed bucketRoot's logic and caused issues with S3 list operations on delimiter+prefix cases. Revert to using path.Join(s3a.bucketRoot(bucket), bucket) which properly handles all bucket types and ensures consistent path resolution across the codebase. The slight performance cost of an extra cache lookup is worth the correctness and consistency benefits. * feat: move table buckets under /buckets Add a table-bucket marker attribute, reuse bucket metadata cache for table bucket detection, and update list/validation/UI/test paths to treat table buckets as /buckets entries. * Fix S3 Tables code review issues - handler_bucket_create.go: Fix bucket existence check to properly validate entryResp.Entry before setting s3BucketExists flag (nil Entry should not indicate existing bucket) - bucket_paths.go: Add clarifying comment to bucketRoot() explaining unified buckets root path for all bucket types - file_browser_data.go: Optimize by extracting table bucket check early to avoid redundant WithFilerClient call * Fix list prefix delimiter handling * Handle list errors conservatively * Fix Trino FOR TIMESTAMP query - use past timestamp Iceberg requires the timestamp to be strictly in the past. Use current_timestamp - interval '1' second instead of current_timestamp. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This commit is contained in:
Chris Lu
@@ -308,7 +308,8 @@ func removeDuplicateSlashes(object string) string {
|
||||
return result.String()
|
||||
}
|
||||
|
||||
// hasChildren checks if a path has any child objects (is a directory with contents)
|
||||
// hasChildren checks if a path has any child objects (is a directory with contents).
|
||||
// On unexpected errors, it logs and conservatively returns true to avoid hiding entries.
|
||||
//
|
||||
// This helper function is used to distinguish implicit directories from regular files or empty directories.
|
||||
// An implicit directory is one that exists only because it has children, not because it was explicitly created.
|
||||
@@ -333,7 +334,7 @@ func (s3a *S3ApiServer) hasChildren(bucket, prefix string) bool {
|
||||
cleanPrefix := strings.TrimPrefix(prefix, "/")
|
||||
|
||||
// The directory to list is bucketDir + cleanPrefix
|
||||
bucketDir := s3a.option.BucketsPath + "/" + bucket
|
||||
bucketDir := s3a.bucketDir(bucket)
|
||||
fullPath := bucketDir + "/" + cleanPrefix
|
||||
|
||||
// Try to list one child object in the directory
|
||||
@@ -361,7 +362,14 @@ func (s3a *S3ApiServer) hasChildren(bucket, prefix string) bool {
|
||||
})
|
||||
|
||||
// If we got an entry (not EOF), then it has children
|
||||
return err == nil
|
||||
if err == nil {
|
||||
return true
|
||||
}
|
||||
if errors.Is(err, io.EOF) || errors.Is(err, filer_pb.ErrNotFound) {
|
||||
return false
|
||||
}
|
||||
glog.V(1).Infof("hasChildren: list entries failed for %s/%s: %v", bucket, cleanPrefix, err)
|
||||
return true
|
||||
}
|
||||
|
||||
// checkDirectoryObject checks if the object is a directory object (ends with "/") and if it exists
|
||||
@@ -374,7 +382,7 @@ func (s3a *S3ApiServer) checkDirectoryObject(bucket, object string) (*filer_pb.E
|
||||
return nil, false, nil // Not a directory object
|
||||
}
|
||||
|
||||
bucketDir := s3a.option.BucketsPath + "/" + bucket
|
||||
bucketDir := s3a.bucketDir(bucket)
|
||||
cleanObject := strings.TrimSuffix(object, "/")
|
||||
|
||||
if cleanObject == "" {
|
||||
@@ -416,7 +424,7 @@ func (s3a *S3ApiServer) resolveObjectEntry(bucket, object string) (*filer_pb.Ent
|
||||
}
|
||||
|
||||
// For non-versioned buckets, verify directly
|
||||
bucketDir := s3a.option.BucketsPath + "/" + bucket
|
||||
bucketDir := s3a.bucketDir(bucket)
|
||||
return s3a.getEntry(bucketDir, object)
|
||||
}
|
||||
|
||||
@@ -542,7 +550,7 @@ func (s3a *S3ApiServer) toFilerPath(bucket, object string) string {
|
||||
// Returns the raw file path - no URL escaping needed
|
||||
// The path is used directly, not embedded in a URL
|
||||
object = s3_constants.NormalizeObjectKey(object)
|
||||
return fmt.Sprintf("%s/%s/%s", s3a.option.BucketsPath, bucket, object)
|
||||
return fmt.Sprintf("%s/%s", s3a.bucketDir(bucket), object)
|
||||
}
|
||||
|
||||
// hasConditionalHeaders checks if the request has any conditional headers
|
||||
@@ -659,7 +667,7 @@ func (s3a *S3ApiServer) GetObjectHandler(w http.ResponseWriter, r *http.Request)
|
||||
// - If .versions/ exists: real versions available, use getLatestObjectVersion
|
||||
// - If .versions/ doesn't exist (ErrNotFound): only null version at regular path, use it directly
|
||||
// - If transient error: fall back to getLatestObjectVersion which has retry logic
|
||||
bucketDir := s3a.option.BucketsPath + "/" + bucket
|
||||
bucketDir := s3a.bucketDir(bucket)
|
||||
normalizedObject := s3_constants.NormalizeObjectKey(object)
|
||||
versionsDir := normalizedObject + s3_constants.VersionsFolder
|
||||
|
||||
@@ -2135,7 +2143,7 @@ func (s3a *S3ApiServer) HeadObjectHandler(w http.ResponseWriter, r *http.Request
|
||||
// - If .versions/ exists: real versions available, use getLatestObjectVersion
|
||||
// - If .versions/ doesn't exist (ErrNotFound): only null version at regular path, use it directly
|
||||
// - If transient error: fall back to getLatestObjectVersion which has retry logic
|
||||
bucketDir := s3a.option.BucketsPath + "/" + bucket
|
||||
bucketDir := s3a.bucketDir(bucket)
|
||||
normalizedObject := s3_constants.NormalizeObjectKey(object)
|
||||
versionsDir := normalizedObject + s3_constants.VersionsFolder
|
||||
|
||||
@@ -2280,7 +2288,7 @@ func (s3a *S3ApiServer) HeadObjectHandler(w http.ResponseWriter, r *http.Request
|
||||
//
|
||||
// Edge Cases Handled:
|
||||
// - Empty files (0-byte, no children) → 200 OK (legitimate empty file)
|
||||
// - Empty directories (no children) → 200 OK (legitimate empty directory)
|
||||
// - Empty directories (no children) → 404 Not Found (directories are not objects)
|
||||
// - Explicit directory requests (trailing slash) → 200 OK (handled earlier)
|
||||
// - Versioned objects → Skip this check (different semantics)
|
||||
//
|
||||
@@ -2293,9 +2301,11 @@ func (s3a *S3ApiServer) HeadObjectHandler(w http.ResponseWriter, r *http.Request
|
||||
// PyArrow may create 0-byte files when writing datasets, or the filer may have actual directories
|
||||
if objectEntryForSSE.Attributes != nil {
|
||||
isZeroByteFile := objectEntryForSSE.Attributes.FileSize == 0 && !objectEntryForSSE.IsDirectory
|
||||
isActualDirectory := objectEntryForSSE.IsDirectory
|
||||
|
||||
if isZeroByteFile || isActualDirectory {
|
||||
if objectEntryForSSE.IsDirectory {
|
||||
s3err.WriteErrorResponse(w, r, s3err.ErrNoSuchKey)
|
||||
return
|
||||
}
|
||||
if isZeroByteFile {
|
||||
// Check if it has children (making it an implicit directory)
|
||||
if s3a.hasChildren(bucket, object) {
|
||||
// This is an implicit directory with children
|
||||
@@ -2414,7 +2424,7 @@ func writeFinalResponse(w http.ResponseWriter, proxyResponse *http.Response, bod
|
||||
// fetchObjectEntry fetches the filer entry for an object
|
||||
// Returns nil if not found (not an error), or propagates other errors
|
||||
func (s3a *S3ApiServer) fetchObjectEntry(bucket, object string) (*filer_pb.Entry, error) {
|
||||
objectPath := fmt.Sprintf("%s/%s/%s", s3a.option.BucketsPath, bucket, object)
|
||||
objectPath := fmt.Sprintf("%s/%s", s3a.bucketDir(bucket), object)
|
||||
fetchedEntry, fetchErr := s3a.getEntry("", objectPath)
|
||||
if fetchErr != nil {
|
||||
if errors.Is(fetchErr, filer_pb.ErrNotFound) {
|
||||
@@ -2428,7 +2438,7 @@ func (s3a *S3ApiServer) fetchObjectEntry(bucket, object string) (*filer_pb.Entry
|
||||
// fetchObjectEntryRequired fetches the filer entry for an object
|
||||
// Returns an error if the object is not found or any other error occurs
|
||||
func (s3a *S3ApiServer) fetchObjectEntryRequired(bucket, object string) (*filer_pb.Entry, error) {
|
||||
objectPath := fmt.Sprintf("%s/%s/%s", s3a.option.BucketsPath, bucket, object)
|
||||
objectPath := fmt.Sprintf("%s/%s", s3a.bucketDir(bucket), object)
|
||||
fetchedEntry, fetchErr := s3a.getEntry("", objectPath)
|
||||
if fetchErr != nil {
|
||||
return nil, fetchErr // Return error for both not-found and other errors
|
||||
@@ -3350,7 +3360,7 @@ func (s3a *S3ApiServer) getMultipartInfo(entry *filer_pb.Entry, partNumber int)
|
||||
// buildRemoteObjectPath builds the filer directory and object name from S3 bucket/object.
|
||||
// This is shared by all remote object caching functions.
|
||||
func (s3a *S3ApiServer) buildRemoteObjectPath(bucket, object string) (dir, name string) {
|
||||
dir = s3a.option.BucketsPath + "/" + bucket
|
||||
dir = s3a.bucketDir(bucket)
|
||||
name = s3_constants.NormalizeObjectKey(object)
|
||||
if idx := strings.LastIndex(name, "/"); idx > 0 {
|
||||
dir = dir + "/" + name[:idx]
|
||||
@@ -3418,7 +3428,7 @@ func (s3a *S3ApiServer) cacheRemoteObjectForStreaming(r *http.Request, entry *fi
|
||||
if versionId != "" && versionId != "null" {
|
||||
// This is a specific version - entry is located at /buckets/<bucket>/<object>.versions/v_<versionId>
|
||||
normalizedObject := s3_constants.NormalizeObjectKey(object)
|
||||
dir = s3a.option.BucketsPath + "/" + bucket + "/" + normalizedObject + s3_constants.VersionsFolder
|
||||
dir = s3a.bucketDir(bucket) + "/" + normalizedObject + s3_constants.VersionsFolder
|
||||
name = s3a.getVersionFileName(versionId)
|
||||
} else {
|
||||
// Non-versioned object or "null" version - lives at the main path
|
||||
|
||||
Reference in New Issue
Block a user