s3api: preserve lifecycle config responses for Terraform (#8805)

* s3api: preserve lifecycle configs for terraform * s3api: bound lifecycle config request bodies * s3api: make bucket config updates copy-on-write * s3api: tighten string slice cloning
2026-03-27 22:50:02 -07:00
parent 0adb78bc6b
commit e3f052cd84
8 changed files with 475 additions and 18 deletions
--- a/weed/s3api/s3api_bucket_lifecycle_response_test.go
+++ b/weed/s3api/s3api_bucket_lifecycle_response_test.go
@@ -0,0 +1,126 @@
+package s3api
+
+import (
+	"errors"
+	"net/http"
+	"net/http/httptest"
+	"strings"
+	"testing"
+	"time"
+
+	"github.com/gorilla/mux"
+	"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
+	"github.com/seaweedfs/seaweedfs/weed/s3api/s3err"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestGetBucketLifecycleConfigurationHandlerUsesStoredLifecycleConfig(t *testing.T) {
+	const bucket = "cleanup-test-net"
+	const lifecycleXML = `<?xml version="1.0" encoding="UTF-8"?><LifecycleConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><Rule><Filter></Filter><ID>rotation</ID><Expiration><Days>1</Days></Expiration><Status>Enabled</Status></Rule></LifecycleConfiguration>`
+
+	s3a := newTestS3ApiServerWithMemoryIAM(t, nil)
+	s3a.option = &S3ApiServerOption{BucketsPath: "/buckets"}
+	s3a.bucketConfigCache = NewBucketConfigCache(time.Minute)
+	s3a.bucketConfigCache.Set(bucket, &BucketConfig{
+		Name: bucket,
+		Entry: &filer_pb.Entry{
+			Extended: map[string][]byte{
+				bucketLifecycleConfigurationXMLKey:            []byte(lifecycleXML),
+				bucketLifecycleTransitionMinimumObjectSizeKey: []byte("varies_by_storage_class"),
+			},
+		},
+	})
+
+	req := httptest.NewRequest(http.MethodGet, "/"+bucket+"?lifecycle", nil)
+	req = mux.SetURLVars(req, map[string]string{"bucket": bucket})
+	resp := httptest.NewRecorder()
+
+	s3a.GetBucketLifecycleConfigurationHandler(resp, req)
+
+	require.Equal(t, http.StatusOK, resp.Code)
+	assert.Equal(t, "varies_by_storage_class", resp.Header().Get(bucketLifecycleTransitionMinimumObjectSizeHeader))
+	assert.Equal(t, lifecycleXML, resp.Body.String())
+}
+
+func TestGetBucketLifecycleConfigurationHandlerDefaultsTransitionMinimumObjectSize(t *testing.T) {
+	const bucket = "cleanup-test-net"
+	const lifecycleXML = `<?xml version="1.0" encoding="UTF-8"?><LifecycleConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><Rule><Filter></Filter><ID>rotation</ID><Expiration><Days>1</Days></Expiration><Status>Enabled</Status></Rule></LifecycleConfiguration>`
+
+	s3a := newTestS3ApiServerWithMemoryIAM(t, nil)
+	s3a.option = &S3ApiServerOption{BucketsPath: "/buckets"}
+	s3a.bucketConfigCache = NewBucketConfigCache(time.Minute)
+	s3a.bucketConfigCache.Set(bucket, &BucketConfig{
+		Name: bucket,
+		Entry: &filer_pb.Entry{
+			Extended: map[string][]byte{
+				bucketLifecycleConfigurationXMLKey: []byte(lifecycleXML),
+			},
+		},
+	})
+
+	req := httptest.NewRequest(http.MethodGet, "/"+bucket+"?lifecycle", nil)
+	req = mux.SetURLVars(req, map[string]string{"bucket": bucket})
+	resp := httptest.NewRecorder()
+
+	s3a.GetBucketLifecycleConfigurationHandler(resp, req)
+
+	require.Equal(t, http.StatusOK, resp.Code)
+	assert.Equal(t, defaultLifecycleTransitionMinimumObjectSize, resp.Header().Get(bucketLifecycleTransitionMinimumObjectSizeHeader))
+	assert.Equal(t, lifecycleXML, resp.Body.String())
+}
+
+func TestPutBucketLifecycleConfigurationHandlerRejectsOversizedBody(t *testing.T) {
+	const bucket = "cleanup-test-net"
+
+	s3a := newTestS3ApiServerWithMemoryIAM(t, nil)
+	s3a.option = &S3ApiServerOption{BucketsPath: "/buckets"}
+	s3a.bucketConfigCache = NewBucketConfigCache(time.Minute)
+	s3a.bucketConfigCache.Set(bucket, &BucketConfig{
+		Name:  bucket,
+		Entry: &filer_pb.Entry{},
+	})
+
+	req := httptest.NewRequest(http.MethodPut, "/"+bucket+"?lifecycle", strings.NewReader(strings.Repeat("x", maxBucketLifecycleConfigurationSize+1)))
+	req = mux.SetURLVars(req, map[string]string{"bucket": bucket})
+	resp := httptest.NewRecorder()
+
+	s3a.PutBucketLifecycleConfigurationHandler(resp, req)
+
+	require.Equal(t, s3err.GetAPIError(s3err.ErrEntityTooLarge).HTTPStatusCode, resp.Code)
+	assert.Contains(t, resp.Body.String(), "<Code>EntityTooLarge</Code>")
+}
+
+func TestPutBucketLifecycleConfigurationHandlerMapsReadErrorsToInvalidRequest(t *testing.T) {
+	const bucket = "cleanup-test-net"
+
+	s3a := newTestS3ApiServerWithMemoryIAM(t, nil)
+	s3a.option = &S3ApiServerOption{BucketsPath: "/buckets"}
+	s3a.bucketConfigCache = NewBucketConfigCache(time.Minute)
+	s3a.bucketConfigCache.Set(bucket, &BucketConfig{
+		Name:  bucket,
+		Entry: &filer_pb.Entry{},
+	})
+
+	req := httptest.NewRequest(http.MethodPut, "/"+bucket+"?lifecycle", nil)
+	req = mux.SetURLVars(req, map[string]string{"bucket": bucket})
+	req.Body = failingReadCloser{err: errors.New("read failed")}
+	resp := httptest.NewRecorder()
+
+	s3a.PutBucketLifecycleConfigurationHandler(resp, req)
+
+	require.Equal(t, s3err.GetAPIError(s3err.ErrInvalidRequest).HTTPStatusCode, resp.Code)
+	assert.Contains(t, resp.Body.String(), "<Code>InvalidRequest</Code>")
+}
+
+type failingReadCloser struct {
+	err error
+}
+
+func (f failingReadCloser) Read(_ []byte) (int, error) {
+	return 0, f.err
+}
+
+func (f failingReadCloser) Close() error {
+	return nil
+}