gsh-digital-services/seaweedFS
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(remote): don't send empty StorageClass in S3 uploads (#8645)

Browse Source 
When S3StorageClass is empty (the default), aws.String("") was passed
as the StorageClass in PutObject requests. While AWS S3 treats this as
"use default," S3-compatible providers (e.g. SharkTech) reject it with
InvalidStorageClass. Only set StorageClass when a non-empty value is
configured, letting the provider use its default.

Fixes #8644
This commit is contained in:
Chris Lu
2026-03-15 13:32:48 -07:00
committed by GitHub
parent 5f19e3259f
commit b868980260
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
weed/remote_storage/s3/s3_storage_client.go
View File

@@ -275,13 +275,16 @@ func (s *s3RemoteStorageClient) WriteFile(loc *remote_pb.RemoteStorageLocation,
} }
// Upload the file to S3. // Upload the file to S3.
_, err = uploader.Upload(&s3manager.UploadInput{ uploadInput := &s3manager.UploadInput{
Bucket: aws.String(loc.Bucket), Bucket: aws.String(loc.Bucket),
Key: aws.String(loc.Path[1:]), Key: aws.String(loc.Path[1:]),
Body: reader, Body: reader,
Tagging: awsTags, Tagging: awsTags,
StorageClass: aws.String(s.conf.S3StorageClass), }
}) if s.conf.S3StorageClass != "" {
uploadInput.StorageClass = aws.String(s.conf.S3StorageClass)
}
_, err = uploader.Upload(uploadInput)
//in case it fails to upload //in case it fails to upload
if err != nil { if err != nil {