gsh-digital-services/seaweedFS
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix: Fail fast on unsupported volume versions (#8047)

Browse Source 
* Fix: Fail fast when initializing volume with Version 0

* Fix: Fail fast when loading unsupported volume version (e.g. 0 or 4)

* Refactor: Use IsSupportedVersion helper function for version validation
This commit is contained in:
Chris Lu
2026-01-16 19:19:18 -08:00
committed by GitHub
parent 0a46577700
commit a473278bfa
3 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
weed/storage/needle/volume_version.go
View File

@@ -11,3 +11,7 @@ const (
func GetCurrentVersion() Version { func GetCurrentVersion() Version {
return Version3 return Version3
} }
func IsSupportedVersion(v Version) bool {
return v >= Version1 && v <= Version3
}

3
weed/storage/volume_loading.go
View File

@@ -106,6 +106,9 @@ func (v *Volume) load(alsoLoadIndex bool, createDatIfMissing bool, needleMapKind
if alreadyHasSuperBlock { if alreadyHasSuperBlock {
err = v.readSuperBlock() err = v.readSuperBlock()
if err == nil { if err == nil {
if !needle.IsSupportedVersion(v.SuperBlock.Version) {
glog.Fatalf("Unsupported volume %d version %v", v.Id, v.SuperBlock.Version)
}
v.volumeInfo.Version = uint32(v.SuperBlock.Version) v.volumeInfo.Version = uint32(v.SuperBlock.Version)
} }
glog.V(2).Infof("readSuperBlock volume %d version %v", v.Id, v.SuperBlock.Version) glog.V(2).Infof("readSuperBlock volume %d version %v", v.Id, v.SuperBlock.Version)

3
weed/storage/volume_super_block.go
View File

@@ -18,6 +18,9 @@ func (v *Volume) maybeWriteSuperBlock(ver needle.Version) error {
return e return e
} }
if datSize == 0 { if datSize == 0 {
if !needle.IsSupportedVersion(ver) {
return fmt.Errorf("volume super block version %d is not supported", ver)
}
v.SuperBlock.Version = ver v.SuperBlock.Version = ver
_, e = v.DataBackend.WriteAt(v.SuperBlock.Bytes(), 0) _, e = v.DataBackend.WriteAt(v.SuperBlock.Bytes(), 0)
if e != nil && os.IsPermission(e) { if e != nil && os.IsPermission(e) {