S3: Add Vary header for non-wildcard AllowOrigin (#7547)
This commit is contained in:
@@ -361,6 +361,10 @@ func ApplyHeaders(w http.ResponseWriter, corsResp *CORSResponse) {
|
|||||||
|
|
||||||
if corsResp.AllowOrigin != "" {
|
if corsResp.AllowOrigin != "" {
|
||||||
w.Header().Set("Access-Control-Allow-Origin", corsResp.AllowOrigin)
|
w.Header().Set("Access-Control-Allow-Origin", corsResp.AllowOrigin)
|
||||||
|
|
||||||
|
if corsResp.AllowOrigin != "*" {
|
||||||
|
w.Header().Add("Vary", "Origin")
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if corsResp.AllowMethods != "" {
|
if corsResp.AllowMethods != "" {
|
||||||
|
|||||||
@@ -480,6 +480,7 @@ func TestApplyHeaders(t *testing.T) {
|
|||||||
"Access-Control-Allow-Headers": "Content-Type",
|
"Access-Control-Allow-Headers": "Content-Type",
|
||||||
"Access-Control-Expose-Headers": "ETag",
|
"Access-Control-Expose-Headers": "ETag",
|
||||||
"Access-Control-Max-Age": "3600",
|
"Access-Control-Max-Age": "3600",
|
||||||
|
"Vary": "Origin",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
@@ -493,6 +494,7 @@ func TestApplyHeaders(t *testing.T) {
|
|||||||
"Access-Control-Allow-Origin": "http://example.com",
|
"Access-Control-Allow-Origin": "http://example.com",
|
||||||
"Access-Control-Allow-Methods": "GET",
|
"Access-Control-Allow-Methods": "GET",
|
||||||
"Access-Control-Allow-Credentials": "true",
|
"Access-Control-Allow-Credentials": "true",
|
||||||
|
"Vary": "Origin",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user