chore: remove ~50k lines of unreachable dead code (#8913)
* chore: remove unreachable dead code across the codebase Remove ~50,000 lines of unreachable code identified by static analysis. Major removals: - weed/filer/redis_lua: entire unused Redis Lua filer store implementation - weed/wdclient/net2, resource_pool: unused connection/resource pool packages - weed/plugin/worker/lifecycle: unused lifecycle plugin worker - weed/s3api: unused S3 policy templates, presigned URL IAM, streaming copy, multipart IAM, key rotation, and various SSE helper functions - weed/mq/kafka: unused partition mapping, compression, schema, and protocol functions - weed/mq/offset: unused SQL storage and migration code - weed/worker: unused registry, task, and monitoring functions - weed/query: unused SQL engine, parquet scanner, and type functions - weed/shell: unused EC proportional rebalance functions - weed/storage/erasure_coding/distribution: unused distribution analysis functions - Individual unreachable functions removed from 150+ files across admin, credential, filer, iam, kms, mount, mq, operation, pb, s3api, server, shell, storage, topology, and util packages * fix(s3): reset shared memory store in IAM test to prevent flaky failure TestLoadIAMManagerFromConfig_EmptyConfigWithFallbackKey was flaky because the MemoryStore credential backend is a singleton registered via init(). Earlier tests that create anonymous identities pollute the shared store, causing LookupAnonymous() to unexpectedly return true. Fix by calling Reset() on the memory store before the test runs. * style: run gofmt on changed files * fix: restore KMS functions used by integration tests * fix(plugin): prevent panic on send to closed worker session channel The Plugin.sendToWorker method could panic with "send on closed channel" when a worker disconnected while a message was being sent. The race was between streamSession.close() closing the outgoing channel and sendToWorker writing to it concurrently. Add a done channel to streamSession that is closed before the outgoing channel, and check it in sendToWorker's select to safely detect closed sessions without panicking.
This commit is contained in:
@@ -268,15 +268,6 @@ func mimeDetect(r *http.Request, dataReader io.Reader) io.ReadCloser {
|
||||
return io.NopCloser(dataReader)
|
||||
}
|
||||
|
||||
func urlEscapeObject(object string) string {
|
||||
normalized := s3_constants.NormalizeObjectKey(object)
|
||||
// Ensure leading slash for filer paths
|
||||
if normalized != "" && !strings.HasPrefix(normalized, "/") {
|
||||
normalized = "/" + normalized
|
||||
}
|
||||
return urlPathEscape(normalized)
|
||||
}
|
||||
|
||||
func entryUrlEncode(dir string, entry string, encodingTypeUrl bool) (dirName string, entryName string, prefix string) {
|
||||
if !encodingTypeUrl {
|
||||
return dir, entry, entry
|
||||
@@ -2895,59 +2886,6 @@ func (m *MultipartSSEReader) Close() error {
|
||||
return lastErr
|
||||
}
|
||||
|
||||
// Read implements the io.Reader interface for SSERangeReader
|
||||
func (r *SSERangeReader) Read(p []byte) (n int, err error) {
|
||||
// Skip bytes iteratively (no recursion) until we reach the offset
|
||||
for r.skipped < r.offset {
|
||||
skipNeeded := r.offset - r.skipped
|
||||
|
||||
// Lazily allocate skip buffer on first use, reuse thereafter
|
||||
if r.skipBuf == nil {
|
||||
// Use a fixed 32KB buffer for skipping (avoids per-call allocation)
|
||||
r.skipBuf = make([]byte, 32*1024)
|
||||
}
|
||||
|
||||
// Determine how much to skip in this iteration
|
||||
bufSize := int64(len(r.skipBuf))
|
||||
if skipNeeded < bufSize {
|
||||
bufSize = skipNeeded
|
||||
}
|
||||
|
||||
skipRead, skipErr := r.reader.Read(r.skipBuf[:bufSize])
|
||||
r.skipped += int64(skipRead)
|
||||
|
||||
if skipErr != nil {
|
||||
return 0, skipErr
|
||||
}
|
||||
|
||||
// Guard against infinite loop: io.Reader may return (0, nil)
|
||||
// which is permitted by the interface contract for non-empty buffers.
|
||||
// If we get zero bytes without an error, treat it as an unexpected EOF.
|
||||
if skipRead == 0 {
|
||||
return 0, io.ErrUnexpectedEOF
|
||||
}
|
||||
}
|
||||
|
||||
// If we have a remaining limit and it's reached
|
||||
if r.remaining == 0 {
|
||||
return 0, io.EOF
|
||||
}
|
||||
|
||||
// Calculate how much to read
|
||||
readSize := len(p)
|
||||
if r.remaining > 0 && int64(readSize) > r.remaining {
|
||||
readSize = int(r.remaining)
|
||||
}
|
||||
|
||||
// Read the data
|
||||
n, err = r.reader.Read(p[:readSize])
|
||||
if r.remaining > 0 {
|
||||
r.remaining -= int64(n)
|
||||
}
|
||||
|
||||
return n, err
|
||||
}
|
||||
|
||||
// PartBoundaryInfo holds information about a part's chunk boundaries
|
||||
type PartBoundaryInfo struct {
|
||||
PartNumber int `json:"part"`
|
||||
|
||||
Reference in New Issue
Block a user