chore: remove ~50k lines of unreachable dead code (#8913)
* chore: remove unreachable dead code across the codebase Remove ~50,000 lines of unreachable code identified by static analysis. Major removals: - weed/filer/redis_lua: entire unused Redis Lua filer store implementation - weed/wdclient/net2, resource_pool: unused connection/resource pool packages - weed/plugin/worker/lifecycle: unused lifecycle plugin worker - weed/s3api: unused S3 policy templates, presigned URL IAM, streaming copy, multipart IAM, key rotation, and various SSE helper functions - weed/mq/kafka: unused partition mapping, compression, schema, and protocol functions - weed/mq/offset: unused SQL storage and migration code - weed/worker: unused registry, task, and monitoring functions - weed/query: unused SQL engine, parquet scanner, and type functions - weed/shell: unused EC proportional rebalance functions - weed/storage/erasure_coding/distribution: unused distribution analysis functions - Individual unreachable functions removed from 150+ files across admin, credential, filer, iam, kms, mount, mq, operation, pb, s3api, server, shell, storage, topology, and util packages * fix(s3): reset shared memory store in IAM test to prevent flaky failure TestLoadIAMManagerFromConfig_EmptyConfigWithFallbackKey was flaky because the MemoryStore credential backend is a singleton registered via init(). Earlier tests that create anonymous identities pollute the shared store, causing LookupAnonymous() to unexpectedly return true. Fix by calling Reset() on the memory store before the test runs. * style: run gofmt on changed files * fix: restore KMS functions used by integration tests * fix(plugin): prevent panic on send to closed worker session channel The Plugin.sendToWorker method could panic with "send on closed channel" when a worker disconnected while a message was being sent. The race was between streamSession.close() closing the outgoing channel and sendToWorker writing to it concurrently. Add a done channel to streamSession that is closed before the outgoing channel, and check it in sendToWorker's select to safely detect closed sessions without panicking.
This commit is contained in:
@@ -5,7 +5,6 @@ import (
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"io"
|
||||
"strings"
|
||||
"time"
|
||||
|
||||
"github.com/seaweedfs/seaweedfs/weed/filer_client"
|
||||
@@ -192,10 +191,6 @@ func (f *FilerStorage) getOffsetPath(group, topic string, partition int32) strin
|
||||
return fmt.Sprintf("%s/offset", f.getPartitionPath(group, topic, partition))
|
||||
}
|
||||
|
||||
func (f *FilerStorage) getMetadataPath(group, topic string, partition int32) string {
|
||||
return fmt.Sprintf("%s/metadata", f.getPartitionPath(group, topic, partition))
|
||||
}
|
||||
|
||||
func (f *FilerStorage) writeFile(path string, data []byte) error {
|
||||
fullPath := util.FullPath(path)
|
||||
dir, name := fullPath.DirAndName()
|
||||
@@ -311,16 +306,3 @@ func (f *FilerStorage) deleteDirectory(path string) error {
|
||||
return err
|
||||
})
|
||||
}
|
||||
|
||||
// normalizePath removes leading/trailing slashes and collapses multiple slashes
|
||||
func normalizePath(path string) string {
|
||||
path = strings.Trim(path, "/")
|
||||
parts := strings.Split(path, "/")
|
||||
normalized := []string{}
|
||||
for _, part := range parts {
|
||||
if part != "" {
|
||||
normalized = append(normalized, part)
|
||||
}
|
||||
}
|
||||
return "/" + strings.Join(normalized, "/")
|
||||
}
|
||||
|
||||
@@ -1,65 +0,0 @@
|
||||
package consumer_offset
|
||||
|
||||
import (
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
)
|
||||
|
||||
// Note: These tests require a running filer instance
|
||||
// They are marked as integration tests and should be run with:
|
||||
// go test -tags=integration
|
||||
|
||||
func TestFilerStorageCommitAndFetch(t *testing.T) {
|
||||
t.Skip("Requires running filer - integration test")
|
||||
|
||||
// This will be implemented once we have test infrastructure
|
||||
// Test will:
|
||||
// 1. Create filer storage
|
||||
// 2. Commit offset
|
||||
// 3. Fetch offset
|
||||
// 4. Verify values match
|
||||
}
|
||||
|
||||
func TestFilerStoragePersistence(t *testing.T) {
|
||||
t.Skip("Requires running filer - integration test")
|
||||
|
||||
// Test will:
|
||||
// 1. Commit offset with first storage instance
|
||||
// 2. Close first instance
|
||||
// 3. Create new storage instance
|
||||
// 4. Fetch offset and verify it persisted
|
||||
}
|
||||
|
||||
func TestFilerStorageMultipleGroups(t *testing.T) {
|
||||
t.Skip("Requires running filer - integration test")
|
||||
|
||||
// Test will:
|
||||
// 1. Commit offsets for multiple groups
|
||||
// 2. Fetch all offsets per group
|
||||
// 3. Verify isolation between groups
|
||||
}
|
||||
|
||||
func TestFilerStoragePath(t *testing.T) {
|
||||
// Test path generation (doesn't require filer)
|
||||
storage := &FilerStorage{}
|
||||
|
||||
group := "test-group"
|
||||
topic := "test-topic"
|
||||
partition := int32(5)
|
||||
|
||||
groupPath := storage.getGroupPath(group)
|
||||
assert.Equal(t, ConsumerOffsetsBasePath+"/test-group", groupPath)
|
||||
|
||||
topicPath := storage.getTopicPath(group, topic)
|
||||
assert.Equal(t, ConsumerOffsetsBasePath+"/test-group/test-topic", topicPath)
|
||||
|
||||
partitionPath := storage.getPartitionPath(group, topic, partition)
|
||||
assert.Equal(t, ConsumerOffsetsBasePath+"/test-group/test-topic/5", partitionPath)
|
||||
|
||||
offsetPath := storage.getOffsetPath(group, topic, partition)
|
||||
assert.Equal(t, ConsumerOffsetsBasePath+"/test-group/test-topic/5/offset", offsetPath)
|
||||
|
||||
metadataPath := storage.getMetadataPath(group, topic, partition)
|
||||
assert.Equal(t, ConsumerOffsetsBasePath+"/test-group/test-topic/5/metadata", metadataPath)
|
||||
}
|
||||
Reference in New Issue
Block a user