Refresh IAM config after policy attachments (#8439)

* Refresh IAM cache after policy attachments

* error handling
This commit is contained in:
Chris Lu
2026-02-25 10:30:05 -08:00
committed by GitHub
parent e3decd2e3b
commit 8c0c7248b3
2 changed files with 65 additions and 0 deletions

View File

@@ -51,6 +51,19 @@ func NewEmbeddedIamApi(credentialManager *credential.CredentialManager, iam *Ide
}
}
func (e *EmbeddedIamApi) refreshIAMConfiguration() error {
if e.reloadConfigurationFunc != nil {
return e.reloadConfigurationFunc()
}
if e.iam == nil {
return nil
}
if err := e.iam.LoadS3ApiConfigurationFromCredentialManager(); err != nil {
return fmt.Errorf("failed to refresh IAM configuration: %w", err)
}
return nil
}
// Constants for service account identifiers
const (
ServiceAccountIDLength = 12 // Length of the service account ID
@@ -903,6 +916,11 @@ func (e *EmbeddedIamApi) AttachUserPolicy(ctx context.Context, values url.Values
return resp, &iamError{Code: iam.ErrCodeServiceFailureException, Error: err}
}
// Best-effort refresh: log any failures but don't fail the API call since the mutation succeeded
if err := e.refreshIAMConfiguration(); err != nil {
glog.Warningf("Failed to refresh IAM configuration after attaching policy %s to user %s: %v", policyName, userName, err)
}
return resp, nil
}
@@ -943,6 +961,11 @@ func (e *EmbeddedIamApi) DetachUserPolicy(ctx context.Context, values url.Values
return resp, &iamError{Code: iam.ErrCodeServiceFailureException, Error: err}
}
// Best-effort refresh: log any failures but don't fail the API call since the mutation succeeded
if err := e.refreshIAMConfiguration(); err != nil {
glog.Warningf("Failed to refresh IAM configuration after detaching policy %s from user %s: %v", policyName, userName, err)
}
return resp, nil
}