From 8802843511ef84b6e218076ba7223f3088dac685 Mon Sep 17 00:00:00 2001 From: chrislu Date: Wed, 30 Oct 2024 09:31:22 -0700 Subject: [PATCH] pass in bytes buffer to avoid possible race condition related to https://github.com/seaweedfs/seaweedfs/issues/6180 --- weed/server/filer_server_handlers_write_upload.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/weed/server/filer_server_handlers_write_upload.go b/weed/server/filer_server_handlers_write_upload.go index 58ea8cda2..cb16eadc3 100644 --- a/weed/server/filer_server_handlers_write_upload.go +++ b/weed/server/filer_server_handlers_write_upload.go @@ -100,7 +100,7 @@ func (fs *FilerServer) uploadReaderToChunks(reader io.Reader, startOffset int64, } wg.Add(1) - go func(offset int64) { + go func(offset int64, buf *bytes.Buffer) { defer func() { bufPool.Put(bytesBuffer) <-bytesBufferLimitChan @@ -124,7 +124,7 @@ func (fs *FilerServer) uploadReaderToChunks(reader io.Reader, startOffset int64, } fileChunksLock.Unlock() } - }(chunkOffset) + }(chunkOffset, bytesBuffer) // reset variables for the next chunk chunkOffset = chunkOffset + dataSize