gsh-digital-services/seaweedFS
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clarfiy errors upon needle CRC mismatches. (#8096)

Browse Source
This commit is contained in:
Lisandro Pin
2026-01-23 19:48:29 +01:00
committed by GitHub
parent a5474c30d1
commit 7e81c0bf0d
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
weed/storage/needle/needle_read_tail.go
View File

@@ -1,7 +1,7 @@
package needle package needle
import ( import (
"errors" "fmt"
"github.com/seaweedfs/seaweedfs/weed/stats" "github.com/seaweedfs/seaweedfs/weed/stats"
. "github.com/seaweedfs/seaweedfs/weed/storage/types" . "github.com/seaweedfs/seaweedfs/weed/storage/types"
@@ -9,7 +9,6 @@ import (
) )
func (n *Needle) readNeedleTail(needleBody []byte, version Version) error { func (n *Needle) readNeedleTail(needleBody []byte, version Version) error {
// for all versions, we need to read the checksum // for all versions, we need to read the checksum
if len(n.Data) > 0 { if len(n.Data) > 0 {
expectedChecksum := CRC(util.BytesToUint32(needleBody[0:NeedleChecksumSize])) expectedChecksum := CRC(util.BytesToUint32(needleBody[0:NeedleChecksumSize]))
@@ -19,7 +18,7 @@ func (n *Needle) readNeedleTail(needleBody []byte, version Version) error {
// with seaweed version using crc.Value() instead of uint32(crc), which appears in commit 056c480eb // with seaweed version using crc.Value() instead of uint32(crc), which appears in commit 056c480eb
// and switch appeared in version 3.09. // and switch appeared in version 3.09.
stats.VolumeServerHandlerCounter.WithLabelValues(stats.ErrorCRC).Inc() stats.VolumeServerHandlerCounter.WithLabelValues(stats.ErrorCRC).Inc()
return errors.New("CRC error! Data On Disk Corrupted") return fmt.Errorf("invalid CRC for needle %v (got %08x, want %08x), data on disk corrupted", n.Id, dataChecksum, expectedChecksum)
} }
n.Checksum = dataChecksum n.Checksum = dataChecksum
} else { } else {