ec.encode: Display a warning on EC balancing if no replica placement settings are found. (#6487)

This commit is contained in:
Lisandro Pin
2025-01-29 17:50:19 +01:00
committed by GitHub
parent 33ba88df9c
commit 7913681297
3 changed files with 53 additions and 12 deletions

View File

@@ -45,6 +45,10 @@ func NewReplicaPlacementFromByte(b byte) (*ReplicaPlacement, error) {
return NewReplicaPlacementFromString(fmt.Sprintf("%03d", b))
}
func (rp *ReplicaPlacement) HasReplication() bool {
return rp.DiffDataCenterCount != 0 || rp.DiffRackCount != 0 || rp.SameRackCount != 0
}
func (a *ReplicaPlacement) Equals(b *ReplicaPlacement) bool {
if a == nil || b == nil {
return false

View File

@@ -12,3 +12,32 @@ func TestReplicaPlacementSerialDeserial(t *testing.T) {
t.Fail()
}
}
func TestReplicaPlacementHasReplication(t *testing.T) {
testCases := []struct {
name string
replicaPlacement string
want bool
}{
{"empty replica placement", "", false},
{"no replication", "000", false},
{"same rack replication", "100", true},
{"diff rack replication", "020", true},
{"DC replication", "003", true},
{"full replication", "155", true},
}
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
rp, err := NewReplicaPlacementFromString(tc.replicaPlacement)
if err != nil {
t.Errorf("failed to initialize ReplicaPlacement: %v", err)
return
}
if got, want := rp.HasReplication(), tc.want; got != want {
t.Errorf("expected %v, got %v", want, got)
}
})
}
}