Unify the parameter to disable dry-run on weed shell commands to -apply (instead of -force). (#7450)
* Unify the parameter to disable dry-run on weed shell commands to --apply (instead of --force). * lint * refactor * Execution Order Corrected * handle deprecated force flag * fix help messages * Refactoring]: Using flag.FlagSet.Visit() * consistent with other commands * Checks for both flags * fix toml files --------- Co-authored-by: chrislu <chris.lu@gmail.com>
This commit is contained in:
@@ -159,3 +159,28 @@ func infoAboutSimulationMode(writer io.Writer, forceMode bool, forceModeOption s
|
||||
}
|
||||
fmt.Fprintf(writer, "Running in simulation mode. Use \"%s\" option to apply the changes.\n", forceModeOption)
|
||||
}
|
||||
|
||||
// handleDeprecatedForceFlag handles the deprecated -force flag by checking if it was
|
||||
// explicitly provided, printing a deprecation warning, and copying its
|
||||
// value to the new flag. This ensures that explicit -force=false takes precedence.
|
||||
func handleDeprecatedForceFlag(writer io.Writer, fs *flag.FlagSet, forceAlias *bool, applyFlag *bool) {
|
||||
forceIsSet := false
|
||||
applyIsSet := false
|
||||
fs.Visit(func(f *flag.Flag) {
|
||||
switch f.Name {
|
||||
case "force":
|
||||
forceIsSet = true
|
||||
case "apply":
|
||||
applyIsSet = true
|
||||
}
|
||||
})
|
||||
|
||||
if forceIsSet {
|
||||
if applyIsSet {
|
||||
fmt.Fprintf(writer, "WARNING: both -force and -apply are set. -force is deprecated and takes precedence. Please use only -apply.\n")
|
||||
} else {
|
||||
fmt.Fprintf(writer, "WARNING: -force is deprecated, please use -apply instead.\n")
|
||||
}
|
||||
*applyFlag = *forceAlias
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user