gsh-digital-services/seaweedFS
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(s3api): improve PutBucketHandler comment for orphaned collection recovery

Browse Source 
Clarify the comment and log message for the case where a collection
exists but the bucket directory is missing, explaining the root cause
(partial deletion) more precisely.
This commit is contained in:
Chris Lu
2026-03-11 13:49:11 -07:00
parent 12b360f499
commit 5208c7c727
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
weed/s3api/s3api_bucket_handlers.go
View File

@@ -251,11 +251,12 @@ func (s3a *S3ApiServer) PutBucketHandler(w http.ResponseWriter, r *http.Request)
} }
} }
// If collection exists but bucket directory doesn't, this is an orphaned state // If collection exists but bucket directory doesn't, this is an inconsistent state
// from a previous bucket deletion where volumes haven't been fully cleaned up yet. // that can occur when a previous bucket deletion partially completed (collection
// Allow the bucket to be recreated by proceeding with directory creation. // deletion failed but directory deletion succeeded, or volumes were recreated).
// Recover by proceeding to create the missing bucket directory.
if collectionExists { if collectionExists {
glog.Warningf("PutBucketHandler: collection exists but bucket directory missing for %s, recreating bucket directory", bucket) glog.Warningf("PutBucketHandler: collection exists but bucket directory missing for %s, recovering by creating bucket directory", bucket)
} }
// Check for x-amz-bucket-object-lock-enabled header BEFORE creating bucket // Check for x-amz-bucket-object-lock-enabled header BEFORE creating bucket