shell: add minCacheAge flag to remote.uncache command (#8225)

* add minCacheAge flag to remote.uncache command #8221 * address code review feedback: add nil check and improve test isolation * address code review feedback: use consistent timestamp in FileFilter
2026-02-05 12:57:27 -08:00
parent f84b70c362
commit 3306abae10
2 changed files with 132 additions and 11 deletions
--- a/weed/shell/command_remote_uncache_test.go
+++ b/weed/shell/command_remote_uncache_test.go
@@ -0,0 +1,104 @@
+package shell
+
+import (
+	"testing"
+	"time"
+
+	"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
+)
+
+func TestFileFilter_matches_minCacheAge(t *testing.T) {
+	now := time.Now().Unix()
+
+	tests := []struct {
+		name        string
+		minCacheAge int64
+		entry       *filer_pb.Entry
+		want        bool
+	}{
+		{
+			name:        "no minCacheAge",
+			minCacheAge: -1,
+			entry: &filer_pb.Entry{
+				Attributes: &filer_pb.FuseAttributes{Crtime: now - 100},
+			},
+			want: true,
+		},
+		{
+			name:        "recent cache, should not match",
+			minCacheAge: 3600,
+			entry: &filer_pb.Entry{
+				Attributes: &filer_pb.FuseAttributes{Crtime: now - 7200},
+				RemoteEntry: &filer_pb.RemoteEntry{
+					LastLocalSyncTsNs: now * 1e9,
+				},
+			},
+			want: false,
+		},
+		{
+			name:        "old cache, should match",
+			minCacheAge: 3600,
+			entry: &filer_pb.Entry{
+				Attributes: &filer_pb.FuseAttributes{Crtime: now - 7200},
+				RemoteEntry: &filer_pb.RemoteEntry{
+					LastLocalSyncTsNs: (now - 4000) * 1e9,
+				},
+			},
+			want: true,
+		},
+		{
+			name:        "no remote entry, uses crtime - recent, should not match",
+			minCacheAge: 3600,
+			entry: &filer_pb.Entry{
+				Attributes: &filer_pb.FuseAttributes{Crtime: now - 100},
+			},
+			want: false,
+		},
+		{
+			name:        "no remote entry, uses crtime - old, should match",
+			minCacheAge: 3600,
+			entry: &filer_pb.Entry{
+				Attributes: &filer_pb.FuseAttributes{Crtime: now - 4000},
+			},
+			want: true,
+		},
+		{
+			name:        "remote entry with 0 sync ts, uses crtime - recent, should not match",
+			minCacheAge: 3600,
+			entry: &filer_pb.Entry{
+				Attributes:  &filer_pb.FuseAttributes{Crtime: now - 100},
+				RemoteEntry: &filer_pb.RemoteEntry{LastLocalSyncTsNs: 0},
+			},
+			want: false,
+		},
+		{
+			name:        "nil attributes, should not match",
+			minCacheAge: 3600,
+			entry: &filer_pb.Entry{
+				Attributes: nil,
+			},
+			want: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			defaultString := ""
+			defaultInt64 := int64(-1)
+			ff := &FileFilter{
+				include:     &defaultString,
+				exclude:     &defaultString,
+				minSize:     &defaultInt64,
+				maxSize:     &defaultInt64,
+				minAge:      &defaultInt64,
+				maxAge:      &defaultInt64,
+				minCacheAge: &tt.minCacheAge,
+				now:         now,
+			}
+
+			if got := ff.matches(tt.entry); got != tt.want {
+				t.Errorf("FileFilter.matches() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}