gsh-digital-services/seaweedFS
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use the correct constant when computing the offset in SearchNeedleFromSortedIndex (#6771)

Browse Source 
NeedleHeaderSize happen to have the same size as NeedleMapEntrySize, except when running the 5 bytes offset variant of Seaweedfs, because it does not contain OffsetSize. This causes ECX corruption on deletes, due to the drifting offset computation (offset is always computed on a basis of 16 bytes per record instead of 17 bytes)

Signed-off-by: Quentin Devos <4972091+Okhoshi@users.noreply.github.com>
This commit is contained in:
Quentin D.
2025-05-09 17:47:53 +02:00
committed by GitHub
parent 97dad06ed8
commit 2ae5b480a6
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
weed/storage/erasure_coding/ec_volume.go
View File

@@ -3,14 +3,13 @@ package erasure_coding
import ( import (
"errors" "errors"
"fmt" "fmt"
"github.com/seaweedfs/seaweedfs/weed/glog"
"math" "math"
"os" "os"
"slices"
"sync" "sync"
"time" "time"
"slices" "github.com/seaweedfs/seaweedfs/weed/glog"
"github.com/seaweedfs/seaweedfs/weed/pb" "github.com/seaweedfs/seaweedfs/weed/pb"
"github.com/seaweedfs/seaweedfs/weed/pb/master_pb" "github.com/seaweedfs/seaweedfs/weed/pb/master_pb"
"github.com/seaweedfs/seaweedfs/weed/pb/volume_server_pb" "github.com/seaweedfs/seaweedfs/weed/pb/volume_server_pb"
@@ -263,7 +262,7 @@ func SearchNeedleFromSortedIndex(ecxFile *os.File, ecxFileSize int64, needleId t
key, offset, size = idx.IdxFileEntry(buf) key, offset, size = idx.IdxFileEntry(buf)
if key == needleId { if key == needleId {
if processNeedleFn != nil { if processNeedleFn != nil {
err = processNeedleFn(ecxFile, m*types.NeedleHeaderSize) err = processNeedleFn(ecxFile, m*types.NeedleMapEntrySize)
} }
return return
} }